Re: Better logging for a unix socket connection failure in a proxy filtering setup

[Victor Duchovni]

On Thu, Sep 02, 2010 at 08:38:20PM -0400, Wietse Venema wrote:

> > Perhaps an improved error logging could save somebody the effort
> > of troubleshooting.
> 

I think Mark is looking for improved logging in the SMTP server when
connections to the proxy fail. Perhaps something along the lines of:

Index: src/smtpd/smtpd_proxy.c
--- src/smtpd/smtpd_proxy.c     6 Feb 2010 07:35:07 -0000       1.1.1.1
+++ src/smtpd/smtpd_proxy.c     3 Sep 2010 12:43:20 -0000
@@ -349,8 +349,10 @@
     /*
      * Connect to proxy.
      */
-    if ((fd = connect_fn(endpoint, BLOCKING, proxy->timeout)) < 0)
+    if ((fd = connect_fn(endpoint, BLOCKING, proxy->timeout)) < 0) {
+       msg_warn("connection to %s failed: %m", proxy->service_name);
        return (smtpd_proxy_rdwr_error(state, 0));
+    }
     proxy->service_stream = vstream_fdopen(fd, O_RDWR);
     /* Needed by our DATA-phase record emulation routines. */
     vstream_control(proxy->service_stream, VSTREAM_CTL_CONTEXT,

-- 
        Viktor.