I expected the same, but our CI test for reproducibility passed without it. I
was surprised. Hopefully I'm about to learn something.
Scott K
On January 30, 2024 4:00:59 PM UTC, Matus UHLAR - fantomas via Postfix-users
<postfix-users@postfix.org> wrote:
>On 30.01.24 10:12, Scott Kitterman via Postfix-users wrote:
>> It looks to me like it does fix it.
>
>Isn't/was't the sort important? (I'd expect it to be)
>
>> On Tuesday, January 30, 2024 9:14:09 AM EST Wietse Venema via Postfix-users
>> wrote:
>>> Scott Kitterman via Postfix-users:
>>> > In case anyone is unfamiliar, you can read about reproducible builds here:
>>> > reproducible-builds.org
>>> >
>>> > It looks like Postfix as shipped is very close to being reproducible. We
>>> > got positive results on reproducibility with the patch below added. Is
>>> > this something you could include in a future release?
>>>
>>> I have "LC_ALL=C" at the top of many shell files, but forgot the
>>> makedefs script. Can you confirm that this fixes the problem?
>>>
>>> Doing "LC_ALL=C" in the middle of one command means we can re-introduce
>>> the problem again with some other change.
>>>
>>> Wietse
>>>
>>> --- /var/tmp/postfix-3.9-20240129/makedefs 2024-01-04 12:50:28.000000000
>>> -0500 +++ ./makedefs 2024-01-30 09:05:47.198434044 -0500
>>> @@ -184,6 +184,8 @@
>>> # New York, NY 10011, USA
>>> #--
>>>
>>> +LC_ALL=C; export LC_ALL
>>> +
>>> # By now all shells must have functions.
>>>
>>> error() {
>>>
>>> > Scott K
>>> >
>>> > diff --git a/makedefs b/makedefs
>>> > index d9dc529..2b376b3 100644
>>> > --- a/makedefs
>>> > +++ b/makedefs
>>> > @@ -211,7 +211,7 @@ echo
>>> > "#----------------------------------------------------------------"
>>> >
>>> > echo "# Start of summary of user-configurable 'make makefiles' options."
>>> > echo "# CCARGS=$CCARGS"
>>> > echo "# AUXLIBS=$AUXLIBS"
>>> >
>>> > -env | grep '^AUXLIBS_' | sed 's/^/# /'
>>> > +env | grep '^AUXLIBS_' | sed 's/^/# /' | LC_ALL=C sort
>>> >
>>> > echo "# shared=$shared"
>>> > echo "# dynamicmaps=$dynamicmaps"
>>> > echo "# pie=$pie"
>
_______________________________________________
Postfix-users mailing list -- postfix-users@postfix.org
To unsubscribe send an email to postfix-users-le...@postfix.org
