Hi Elias -- On Friday, September 11, 2020 4:40 PM, Elias M. Mariani <[email protected]> wrote:
> Hi ports@ > > I recently updated x11/terminator that had a dependency on > "devel/py-notify". > I noticed that they had switched to using py-gobject3 to access the > libnotify library some time ago and this went unnoticed because > py-notify installs libnotify. > > I think that it's the same case with audio/exaile. py-notify is not > needed, only libnotify. > https://github.com/exaile/exaile/blob/4.0.2/plugins/notify/init.py#L42 > > According to the documentation in the project, libnotify is not > required for exaile to work. It's needed for the notify plugin. > https://github.com/exaile/exaile/blob/4.0.2/DEPS#L85 > > The tests are returning the same results with or without py-notify. > (The tests are broken, py-test is needed). > > Find attached a diff: > > - Removing libnotify completely. If it's needed for a given plugin, > I think that we should add the rest of the RDEPS for all the other > plugins that we can cover or none at all. I'm flexible with libnotify > only because it has been there for a while... > I have not used exaile in a long time, and perhaps I should be removed as maintainer, but when I did use it I heavily depended on the libnotify functionality. If I was still a user of exaile I would be very unhappy to see it go. But I won't stand in the way if this is the direction chosen. I can look at the tests a little bit later, if no one else beats me to it. ~Brian > - Removing py-nose as TEST_DEPENDS. > > - Using py-test to run (fix?) the tests. > > Tested OK on amd64. > > My dark motivation for all this is to remove one of the two > dependencies that remain on py-notify. > Next I will check print/hplip, the only consumer remaining. > > Cheers. > mariani@ > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/audio/exaile/Makefile,v > retrieving revision 1.42 > diff -u -p -r1.42 Makefile > --- Makefile 9 Jun 2020 16:11:50 -0000 1.42 > +++ Makefile 11 Sep 2020 19:58:42 -0000 > @@ -6,6 +6,7 @@ COMMENT = music manager and player for G > > V = 4.0.2 > DISTNAME = exaile-${V} > +REVISION = 0 > > CATEGORIES = audio x11 > > @@ -22,7 +23,7 @@ MODULES = lang/python > COMMON_DEPENDS = audio/py-cddb>=1.4${MODPY_FLAVOR} \ > > audio/py-mutagen>=1.11${MODPY_FLAVOR} \\ > > devel/py-gobject3${MODPY_FLAVOR} \\ > > > - devel/py-notify>=0.1.1${MODPY_FLAVOR} \\ > > > > - graphics/py-cairo${MODPY_FLAVOR} \\ > multimedia/gstreamer1/core \\ > multimedia/gstreamer1/plugins-good \\ > x11/dbus-python>=0.82.1${MODPY_FLAVOR} > > > > @@ -37,10 +38,9 @@ RUN_DEPENDS = ${COMMON_DEPENDS} \ > > USE_GMAKE = Yes > > -TEST_TARGET= test > +MODPY_PYTEST = Yes > PORTHOME = ${WRKDIR} > -TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \ > > - devel/py-mox3${MODPY_FLAVOR} > > > > +TEST_DEPENDS= devel/py-mox3${MODPY_FLAVOR} > TEST_ENV= EXAILE_DIR=${WRKOBJ}/test > > CONFIGURE_STYLE =none
