On Tue, Sep 08, 2020 at 01:58:09PM +0200, Theo Buehler wrote:
> On Tue, Sep 08, 2020 at 10:33:41AM +0200, Remi Locherer wrote:
> > On Tue, Sep 01, 2020 at 05:59:03PM +0200, Remi Locherer wrote:
> > > This updates rsyslog to version 8.2008.0. The extensive changelog can be
> > > found here: https://github.com/rsyslog/rsyslog/blob/v8.2008.0/ChangeLog
> > >
> > > One notable change is improved support for OpenSSL and also LibreSSL. But
> > > I did not test that yet. Our port is still using GnuTLS.
> > >
> > > I'm not sure if I should switch rsyslogd from GnuTLS to LibreSSL. I see
> > > the main purpose of rsyslogd on OpenBSD in iterop testing of our
> > > syslogd. For this the use of GnuTLS might be beneficial (except the
> > > slow startup on bluhm's test machine ;-) ). Another usage is writing
> > > messages to different databases or mangling logs.
> > >
> > > Are there any users of this port? If so: how are you using it?
> > >
> > > I tested this update on amd64 with the regress test from rsyslogd.
> > > In addition I verified that the following modules work:
> > > imudp, omrelp (with tls=on), imrelp (with tls=on), ommysql
> > >
> > > OK for the port update?
> >
> > I understand that probably nobody is using rsyslog on OpenBSD. ;-)
> > Nevertheless, can I get an OK?
>
> It would be much nicer to inline the diff rather than quoting it :)
yes, of course ;-)
>
> It looks ok portswise and builds fine on amd64 and sparc64. I think
> it'll have better chances of seeing tests if you put this in now rather
> than waiting longer.
>
> ok tb.
>
> There is one somewhat scary warning during the build but it's not new:
>
I'll add this to my todo list and inform upstream about it.
> imuxsock.c:1112:44: warning: cast from 'char *' to 'struct cmsghdr *'
> increases required
> alignment from 1 to 4 [-Wcast-align]
> for(cm = CMSG_FIRSTHDR(&msgh); cm; cm =
> CMSG_NXTHDR(&msgh, cm)) {
>
> ^~~~~~~~~~~~~~~~~~~~~~
> /usr/include/sys/socket.h:499:6: note: expanded from macro 'CMSG_NXTHDR'
> (struct cmsghdr *)((char *)(cmsg) + _ALIGN((cmsg)->cmsg_len)))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
