On 2020/09/01 11:31, wen heping wrote: > > > ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ > 发件人: Stuart Henderson <[email protected]> > 发送时间: 2020年9月1日 17:29 > 收件人: wen heping <[email protected]> > 抄送: [email protected] <[email protected]> > 主题: Re: [Update]textproc/p5-PDF-API2 : Update to 2.038 > > On 2020/09/01 07:43, wen heping wrote: > > Hi, > > > > Here is a patch to for textproc/p5-PDF-API2: > > i) Update to 2.038 > > ii) Add a TEST_DEPENDS > > iii) Add MAKE_ENV=TEST_POD=Yes, now it could do more tests > > I've committed the version update but I don't see the point in running > author tests here, they don't give us any information about how the port > runs on OpenBSD. > > With the author tests, it will check the POD.
And run perlcritic on it, "these tests are for testing by the author" What's the point? > > A new port textproc/p5-PDF-API2-XS should be created first. > > It is optional (and currently only helps if you embed PNGs) so I have > skipped that for now. Tweaked version attached (I take maintainership, > I need PDF::API2 for work and don't want surprises there ;) > > Without p5-PDF-API2-XS, it is no need update to 2.038 since this is the > only change from 2.037. Yes but then it's in place ready for if I get an OK to import the XS module. > Any OK to import? >
