On 2020/08/19 10:59, Edd Barrett wrote:
> Hi,
>
> On Sun, Aug 02, 2020 at 09:21:06AM +0100, Laurence Tratt wrote:
> > gromit-mpx-1.3.1 is now out (amongst other changes, this now warns
> > when it can't grab hotkeys, as some environments like XFCE prevent
> > this). Please find attached (as well as the not-changed versions of
> > the companion ports).
>
> Some comments thus far:
>
> libindicator:
>
> ```
> $ make port-lib-depends-check
> libindicator-12.10.1(x11/libindicator):
> Missing: c++.5 (/usr/local/libexec/indicator-loader3) (system lib)
> Missing: c++abi.3 (/usr/local/libexec/indicator-loader3) (system lib)
> WANTLIB += ${COMPILER_LIBCXX}
> ```
>
> Some of the paths in the PLIST include what appears to be some kind of version
> number (although not that of libindicator). E.g.:
> include/libindicator3-0.4/*
> lib/pkgconfig/indicator3-0.4.pc
>
> It might be OK for the headers to include the version, as pkg-config could
> provide the right path, but isn't it kind of annoying for consumers to have to
> provide that exact version string when asking pkg-config for the flags?
>
> ```
> $ pkg-config --cflags indicator3
> Package indicator3 was not found in the pkg-config search path
> $ pkg-config --cflags indicator3-0.4
> -I/usr/local/include/libindicator3-0.4 -I/usr/local/include/gtk-3.0 ...
> ```
>
> Oddly enough, libappindicator asks pkg-config for hard-coded indicator3-0.4.
That's how it is normally done with ports using this scheme; patching to
change this (i.e. be different than every other OS) will result in more
work patching now and at update time.
