On Tue, 11 Aug 2020 09:13:22 +0200 Solene Rapenne <[email protected]> wrote:
> On Mon, 10 Aug 2020 09:40:26 +0200 > 3un0s <[email protected]>: > > > On Tue, 7 Jul 2020 16:28:08 +0200 > > 3un0s <[email protected]> wrote: > > > > > On Tue, 7 Jul 2020 16:16:35 +0200 > > > Landry Breuil <[email protected]> wrote: > > > > > > > you sent your last mail 8 hours ago, it's a bit early for a > > > > ping. > > > > > > Sorry about that, I'm new here and I didn't really know how long > > > one should wait, again sorry. > > > > > > > moreover, it's common for python stuff on pip to not have tests, > > > > they're in github because github tags are not actual releases > > > > and are a tarball of what's in the repo at the time of the > > > > tagging. github tarballs have been unreliable in the past, but > > > > some claim it's not true anymore. > > > > > > > > personally, for the few python ports i care about, i keep the > > > > github stuff commented out in the Makefile and enable it just > > > > to run the tests locally before commiting, only trusting the > > > > pypi tarballs in the end. > > > > > > > > Landry > > > > > > > > > > Okay, so I'll just leave it how it is now. > > > > > > Any comments or OK? > > > > > > > ping > > > > > the ports looks fine to me, except the variable values should be all > aligned by adding an extra tab, that would look much better. > > ok solene@ for import > Should I do it or it will be done while merging?
