On Sun, Aug 02, 2020 at 05:24:39PM +0200, Paco Esteban wrote:
> On Sat, 01 Aug 2020, Stuart Henderson wrote:
>
> > On 2020/08/01 17:40, Paco Esteban wrote:
> > > On Sat, 01 Aug 2020, Landry Breuil wrote:
> > >
> > > > Hi,
> > > >
> > > > here's an update to goaccess 1.4 (cf
> > > > http://goaccess.io/release-notes#release-1.4), drops the tokyocabinet
> > > > flavor (dep dropped upstream), removed some patches from upstream, i
> > > > have to admit i'm a bit puzzled by the src/settings.c patch, upstream
> > > > code was modified a bit there.
> > > >
> > > > feedback/testing welcome !
> > >
> > > Tested with combined logs from httpd. On the config file I've
> > > uncommented:
> > >
> > > # httpd(8) combined log format
> > > date-format %d/%b/%Y
> > > time-format %T %z
> > > log-format %v %h %^ %^ [%d:%t] "%r" %s %b "%R" "%u"
> > >
> > > It crashes for me with this error:
> > >
> > > GoAccess - version 1.4 - Aug 1 2020 17:35:48
> > > Config file: No config file used
> > >
> > > Fatal error has occurred
> > > Error occurred at: src/goaccess.c - set_curses - 1411
> > > No time format was found on your conf file.
> > >
> > > I have to explicitly specify the config file with
> > > `--config-file=/etc/goaccess.conf`. After that it works fine. Could it
> > > be related to that patch that you were talking about ?
> > >
> > > Cheers,
> > >
> > > --
> > > Paco Esteban.
> > > 0x5818130B8A6DBC03
> >
> > Oh, sounds like they messed up the fix afterwards then :(
>
> I think I've found the issue. I had to add a new patch to src/util.c.
> They were trying to get the config file from
> ${SYSCONFDIR}/goaccess/goaccess.conf and we put it on
> ${SYSCONFDIR}/goaccess.conf
>
> Here's the updated patch. With this it works fine for me on amd64.
Sure, but maybe we should follow upstream and @sample the file in
${SYSCONFDIR}/goaccess/goaccess.conf as it was apparently a deliberate
change in
https://github.com/allinurl/goaccess/commit/91d3adaddd0a53cd23373f2ee1480de610bc4439#
..
