On 2020/06/28 20:34, clematis wrote:
> > It build/install/run OK on amd64. I would appreciate feedback to confirm
> > the python FLAVORING is done properly. Thanks ajacoutot@ for pointing me
> > to the use of devel/py-gobject3${MODPY_FLAVOR} (and not just ${FLAVOR}).
> >
> > I've opened an issue upstream (Ref; #142) to add tests/
> > If they do I will make sure to add this to the next update.
>
> Upstream has no interest in maintaining their pypi nor add test there. So I've
> switched to their gitlab as MASTER_SITES.
> I have some errors trying to run make test. Plus it says it's deprecated
> and this method will be removed inviting to use tox. So I kept the
> NO_TEST = yes There's a few example to run manual test and coverage
> available on the project page. I don't know if that's ok to keep it this
> way.
If the tests don't work anyway, you might as well just use pypi and
avoid the on-the-fly generated 10MB tarballs (which might change hash
if they update git, gitlab, gzip, tar, etc) and just use the 30K ones.
> > I've used it successfully on pictures and pdfs.
>
> I've also re-arranged the Makefile to follow the template order more
> strictly. It still builds and runs OK on amd64. portcheck OK.
> Worked as expected via the command line on pictures and pdfs (which is my only
> use case).
Other problems:
- line things up with tabs (8 col width) not spaces
- Yes/No not YES/NO
- LIB_DEPENDS *must* have an associated WANTLIB, if there is not a
WANTLIB then it's BUILD and/or RUN_DEPENDS
- if a variable is at the default value (at least DISTFILES, EXTRACT_SUFX
in this) don't set it in the Makefile
- use *either* FLAVOR=python3 FLAVORS=python3 (for something which is
a module, package named py-*) *or* MODPY_VERSION, not both
- no , before ${MODPY_FLAVOR}
- there is no python3 version of py-poppler so it's not going to be
doing anything useful for this port
- setuptools is auto added as a dependency when MODPY_SETUPTOOLS is set
- standard for python ports is to set the version number in the
egg-info files/dirs in MODPY_EGG_VERSION so that it's subst'ed with a
variable in the PLIST
- mind the \ at the end of blocks setting variables
diff for the above below.
upstream has a fairly prominent warning about it being in beta on the
readme and not using it for anything critical, should that be copied
to pkg/DESCR?
> > More tests, comments, feedback will be appreciated.
>
> That would still be appreciated. It's meant to have a service menu for
> Dolphin and an extension for Nautilus so if anyone wants to give this a
> try it would be a plus.
>
>
> New tarball including the changes mentioned above attached.
> Cheers,
> --
> clematis (0xA2C87EDB507B4C53)
diff b59de2620f6c14ee88ecdea20ece040a6a11adf2 /usr/ports/mystuff
blob - 319a98de2009039b309a961b0795810e0430d253
file + security/mat2/Makefile
--- security/mat2/Makefile
+++ security/mat2/Makefile
@@ -1,42 +1,35 @@
# $OpenBSD$
-COMMENT = metadata anonymisation toolkit
+COMMENT = metadata anonymisation toolkit
-V = 0.11.0
-DISTNAME = mat2-${V}
-DISTFILES = mat2-${V}${EXTRACT_SUFX}
+MODPY_EGG_VERSION = 0.11.0
+DISTNAME = mat2-${MODPY_EGG_VERSION}
-CATEGORIES = security
+CATEGORIES = security
-HOMEPAGE = https://0xacab.org/jvoisin/mat2
-MAINTAINER = Clem Atis <[email protected]>
+HOMEPAGE = https://0xacab.org/jvoisin/mat2
+MAINTAINER = Clem Atis <[email protected]>
# LGPLv3
-PERMIT_PACKAGE = YES
+PERMIT_PACKAGE = Yes
-MASTER_SITES = https://0xacab.org/jvoisin/mat2/\-/archive/${V}/
-EXTRACT_SUFX = .tar.gz
+MODULES = lang/python
+MODPY_PI = Yes
+MODPY_SETUPTOOLS = Yes
+MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
-MODULES = lang/python
-MODPY_PI = NO
-MODPY_SETUPTOOLS = YES
-MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
-FLAVOR ?=
-FLAVORS = python3
+RUN_DEPENDS = audio/py-mutagen${MODPY_FLAVOR} \
+ devel/py-gobject3${MODPY_FLAVOR} \
+ graphics/py-cairo${MODPY_FLAVOR}
-RUN_DEPENDS = audio/py-mutagen,${MODPY_FLAVOR} \
- graphics/py-cairo,${MODPY_FLAVOR} \
- devel/py-gobject3${MODPY_FLAVOR}
+RUN_DEPENDS += graphics/ffmpeg \
+ graphics/gdk-pixbuf2 \
+ graphics/p5-Image-ExifTool \
+ print/poppler,-main \
+ x11/gtk+3 \
+ x11/gnome/librsvg
-LIB_DEPENDS = print/py-poppler \
- devel/py-setuptools \
- graphics/gdk-pixbuf2 \
- x11/gtk+3 \
- x11/gnome/librsvg \
- graphics/ffmpeg \
- graphics/p5-Image-ExifTool \
-
# test deprecated - upstream encourage to use tox
-NO_TEST = Yes
+NO_TEST = Yes
.include <bsd.port.mk>
blob - d94932f82b60c88ebbb6cea690da2ff39e6614c7
file + security/mat2/distinfo
--- security/mat2/distinfo
+++ security/mat2/distinfo
@@ -1,2 +1,2 @@
-SHA256 (mat2-0.11.0.tar.gz) = w3vhGfS8YiYlfNcgSLuk6vO7JKYv04wqNNm5N+a9Nrc=
-SIZE (mat2-0.11.0.tar.gz) = 10151787
+SHA256 (mat2-0.11.0.tar.gz) = vrmZZetB6+AitqvtlBqg0jiC4mtLS0j5QpWRGmN/kP8=
+SIZE (mat2-0.11.0.tar.gz) = 30853
blob - 009183f688730c79f80ba3c5a6fd3e11d1e5e7ef
file + security/mat2/pkg/PLIST
--- security/mat2/pkg/PLIST
+++ security/mat2/pkg/PLIST
@@ -32,9 +32,9 @@ lib/python${MODPY_VERSION}/site-packages/libmat2/pdf.p
lib/python${MODPY_VERSION}/site-packages/libmat2/torrent.py
lib/python${MODPY_VERSION}/site-packages/libmat2/video.py
lib/python${MODPY_VERSION}/site-packages/libmat2/web.py
-lib/python${MODPY_VERSION}/site-packages/mat2-0.11.0-py${MODPY_VERSION}.egg-info/
-lib/python${MODPY_VERSION}/site-packages/mat2-0.11.0-py${MODPY_VERSION}.egg-info/PKG-INFO
-lib/python${MODPY_VERSION}/site-packages/mat2-0.11.0-py${MODPY_VERSION}.egg-info/SOURCES.txt
-lib/python${MODPY_VERSION}/site-packages/mat2-0.11.0-py${MODPY_VERSION}.egg-info/dependency_links.txt
-lib/python${MODPY_VERSION}/site-packages/mat2-0.11.0-py${MODPY_VERSION}.egg-info/requires.txt
-lib/python${MODPY_VERSION}/site-packages/mat2-0.11.0-py${MODPY_VERSION}.egg-info/top_level.txt
+lib/python${MODPY_VERSION}/site-packages/mat2-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/
+lib/python${MODPY_VERSION}/site-packages/mat2-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO
+lib/python${MODPY_VERSION}/site-packages/mat2-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
+lib/python${MODPY_VERSION}/site-packages/mat2-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
+lib/python${MODPY_VERSION}/site-packages/mat2-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
+lib/python${MODPY_VERSION}/site-packages/mat2-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
