Hello!

I ported akpop3d to NetBSD and found the Subject.

GCC warning was the following:
authenticate.c: In function 'is_user_allowed':
authenticate.c:110:11: warning: switch condition has boolean value
[-Wswitch-bool]
   switch (user_in_file(user,POP3ALLOW_FILE)>0) {
           ^

Please look at the patches below.


--
Alexei


Index: patch-authenticate_c
===================================================================
RCS file: /cvs/ports/mail/akpop3d/patches/patch-authenticate_c,v
retrieving revision 1.2
diff -u -p -r1.2 patch-authenticate_c
--- patch-authenticate_c        22 May 2017 20:03:43 -0000      1.2
+++ patch-authenticate_c        27 Apr 2020 21:42:16 -0000
@@ -17,7 +17,7 @@ Index: authenticate.c
    int allow, deny;
 
 -  switch (user_in_file(user,"/etc/pop3.allow")>0) {
-+  switch (user_in_file(user,POP3ALLOW_FILE)>0) {
++  switch (user_in_file(user,POP3ALLOW_FILE)) {
      case 0:
        allow = 0;
        break;

Index: Makefile
===================================================================
RCS file: /cvs/ports/mail/akpop3d/Makefile,v
retrieving revision 1.13
diff -u -p -r1.13 Makefile
--- Makefile    12 Jul 2019 20:47:24 -0000      1.13
+++ Makefile    27 Apr 2020 21:48:43 -0000
@@ -3,7 +3,7 @@
 COMMENT=       small and secure POP3 daemon
 
 DISTNAME=      akpop3d-0.7.7
-REVISION =     3
+REVISION =     4
 CATEGORIES=    mail
 HOMEPAGE=      http://www.synflood.at/akpop3d.html
 

.

Reply via email to