On Mon, Apr 13, 2020 at 12:47:47PM -0400, Kurt Mosiejczuk wrote:
> Two things cause the build to fail on sparc64: "-Werror" and the need
> for C99.
>
> There are a bunch of deprecated functions that throw warnings and -Werror
> aborts the build, so there is a patch to remove that from meson.build.
>
> The C99 is fixed by adding -std=gnu99 to CFLAGS.
>
> This patch fixes the build on sparc64 (And presumably other base-gcc
> arches).
Can you put the same comment in the patch please.
So that I can remove all these tweaks once sparc64 moves to llvm.
>
> cc maintainer
>
> ok?
>
> --Kurt
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/spice-gtk/Makefile,v
> retrieving revision 1.45
> diff -u -p -r1.45 Makefile
> --- Makefile 3 Apr 2020 10:32:09 -0000 1.45
> +++ Makefile 13 Apr 2020 16:30:50 -0000
> @@ -65,4 +65,7 @@ CONFIGURE_ARGS += -Dpolkit=disabled
> # XXX requires the makecontext function (ucontext)
> CONFIGURE_ARGS += -Dcoroutine=gthread
>
> +# base-gcc doesn't default to c99
> +CFLAGS += -std=gnu99
> +
> .include <bsd.port.mk>
> Index: patches/patch-subprojects_spice-common_meson_build
> ===================================================================
> RCS file: patches/patch-subprojects_spice-common_meson_build
> diff -N patches/patch-subprojects_spice-common_meson_build
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-subprojects_spice-common_meson_build 13 Apr 2020
> 16:30:50 -0000
> @@ -0,0 +1,15 @@
> +$OpenBSD$
> +
> +Deprecated functions means -Werror aborts the build
> +
> +Index: subprojects/spice-common/meson.build
> +--- subprojects/spice-common/meson.build.orig
> ++++ subprojects/spice-common/meson.build
> +@@ -12,7 +12,6 @@ endif
> +
> + # some global vars
> + spice_common_global_cflags = ['-DG_LOG_DOMAIN="Spice"',
> +- '-Werror',
> + '-Wno-unused-parameter']
> +
> + if get_option('alignment-checks')
>
--
Antoine
