On Sat, Mar 28 2020, Greg Steuck <[email protected]> wrote: > On Mon, Jan 13, 2020 at 9:29 AM Alex Holst <[email protected]> wrote: > >> > I'm looking for feedback about the trade-offs of such changes. >> Hi. This seems like needless churn to me. Upstream should be nudged to >> do a new release instead. >> > > Done. > > The local patches got rolled in. Library version bump seems > unnecessary based on the diff: > https://github.com/signalapp/libsignal-protocol-c/compare/v2.3.2...v2.3.3
Looks good ports-wise, ok jca@ > make test: > > Test project /home/greg/ports/pobj/libsignal-protocol-c-2.3.3/build-amd64 > Start 1: test_curve25519 > 1/13 Test #1: test_curve25519 .................. Passed 1.56 sec > Start 2: test_hkdf > 2/13 Test #2: test_hkdf ........................ Passed 0.02 sec > Start 3: test_ratchet > 3/13 Test #3: test_ratchet ..................... Passed 0.04 sec > Start 4: test_protocol > 4/13 Test #4: test_protocol .................... Passed 0.05 sec > Start 5: test_session_record > 5/13 Test #5: test_session_record .............. Passed 0.04 sec > Start 6: test_session_cipher > 6/13 Test #6: test_session_cipher .............. Passed 0.44 sec > Start 7: test_session_builder > 7/13 Test #7: test_session_builder ............. Passed 0.40 sec > Start 8: test_key_helper > 8/13 Test #8: test_key_helper .................. Passed 0.02 sec > Start 9: test_simultaneous_initiate > 9/13 Test #9: test_simultaneous_initiate ....... Passed 1.94 sec > Start 10: test_sender_key_record > 10/13 Test #10: test_sender_key_record ........... Passed 0.03 sec > Start 11: test_group_cipher > 11/13 Test #11: test_group_cipher ................ Passed 2.20 sec > Start 12: test_fingerprint > 12/13 Test #12: test_fingerprint ................. Passed 0.21 sec > Start 13: test_device_consistency > 13/13 Test #13: test_device_consistency .......... Passed 0.04 sec > > 100% tests passed, 0 tests failed out of 13 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
