This option has been a simple "Yes" or "No" switch for quite some time,
devel/qmake is the only user in-tree that checks for non-boolean values.

Am I missing something or can we simply check whether ports want a
separate build directory or not and prepare WRKBUILD accordingly?

Feedback? OK?


Index: qmake.port.mk
===================================================================
RCS file: /cvs/ports/devel/qmake/qmake.port.mk,v
retrieving revision 1.9
diff -u -p -r1.9 qmake.port.mk
--- qmake.port.mk       2 Dec 2017 21:38:10 -0000       1.9
+++ qmake.port.mk       19 Mar 2020 21:11:18 -0000
@@ -91,10 +91,7 @@ CONFIGURE_ENV +=     ${MODQMAKE_ENV}
 MAKE_ENV +=            ${MODQMAKE_ENV}
 
 SEPARATE_BUILD ?=      Yes
-. if ${SEPARATE_BUILD:L} != "no"
-.  if ${SEPARATE_BUILD:L} != "yes"
-ERRORS +=      "Fatal: qmake supports only simple SEPARATE_BUILD builds."
-.  endif
+. if ${SEPARATE_BUILD:L} == "yes"
 # "Shadow builds" of qmake can only work in subdirectory
 WRKBUILD ?=            ${WRKSRC}/build-${MACHINE_ARCH}
 . endif

Reply via email to