On Thu, Mar 05, 2020 at 08:59:45PM +0000, Stuart Henderson wrote:
> On 2020/03/01 20:12, Sebastien Marie wrote:
> > Hi,
> >
> > The following diff adds few magic to devel/cargo module in order to use
> > system
> > libraries instead of building embedded version in crates in an automatic
> > way.
> >
> > It works by removing source library from a defined set of crates. So it
> > will be
> > not possible to build the embedded library (the build will fail instead of
> > silenciously build embedded version).
> >
> > It also provides magic to help configuring crates to use system library.
> >
> > Please note it is still the responsability of the maintainer to add
> > LIB_DEPENDS
> > and WANTLIB in the port.
>
> I think this makes sense, normally I think it would be "too much magic" but
> in the case of rust ports, things are already so complicated I think they
> need all the help we can give them ;)
I finally commited it. I am still considering another way to deal with such
problem, in a more generic way (and to be able to deal with crates vendored as
in firefox or librsvg), but it will take time to properly design it.
> > file + security/sn0int/Makefile
> > --- security/sn0int/Makefile
> > +++ security/sn0int/Makefile
>
> This one should use something like:
>
> MODULES= lang/lua
> MODLUA_VERSION= 5.2
> MODLUA_SA= Yes
> LIB_DEPENDS= ... ${MODLUA_LIB_DEPENDS}
> WANTLIB+= ... ${MODLUA_WANTLIB}
>
Thanks: I changed my diff for sn0int to match your.
--
Sebastien Marie
