On Wed, Mar 04 2020, Stuart Henderson <[email protected]> wrote:
> On 2020/03/04 12:26, Frederic Cambus wrote:
>> > Agreed, in the case of old geoip1 the filenames were pretty much fixed and
>> > the @sample method made sense (plus you might run an update tool to fetch
>> > new files in place of the old ones). For maxminddb it seems standard to
>> > configure the filename instead and if users are updating separately it
>> > would seem sensible to use different files for it, so I think it would
>> > be better to skip the @sample and just set PREFIX instead so they are
>> > installed directly to ${LOCALSTATEDIR}/db/dbip..
>>
>> Makes sense, thanks for providing the details and rationale.
>>
>> Here is a new revision to address the PLIST and PREFIX parts.
Fine with me, ok jca@
> Can I suggest this change?
>
> Makefile.inc:
>
> V = 2020-03
>
> foo/Makefile:
>
> DISTNAME = dbip-foo-lite-${V}.mmdb
> PKGNAME = dbip-foo-lite-${V:S/-/./}.mmdb
>
> Then you don't need to touch foo/Makefile for each update, only Makefile.inc.
No opinion, Frederic please pick whatever works for you. :)
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
