> Sent: Tuesday, February 11, 2020 at 9:02 PM
> From: "Stuart Henderson" <[email protected]>
> To: ports <[email protected]>, "Pierre-Emmanuel André" <[email protected]>
> Subject: postgresql readme
>
> It's always annoying to look through postgresql.conf to figure out which
> things you've changed and which are default settings.
>
> Fortunately with postgresql-previous we have a default postgresql.conf
> that's likely to be close to the one in the old version, so we can diff it
> to give a better picture. It's not perfect because it may have changed
> slightly in a minor release, and initdb makes some locale-related
> changes when it copies the file to /var/postgresql/data, but it beats
> going through 700+ lines by eye.
>
> OK to add that to the pkg-readme?
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/databases/postgresql/Makefile,v
> retrieving revision 1.259
> diff -u -p -r1.259 Makefile
> --- Makefile 9 Feb 2020 09:38:45 -0000 1.259
> +++ Makefile 11 Feb 2020 20:57:45 -0000
> @@ -16,7 +16,7 @@ PKGNAME-docs= postgresql-docs-${VERSION}
> PKGNAME-contrib=postgresql-contrib-${VERSION}
> PKGNAME-plpython=postgresql-plpython-${VERSION}
> PKGNAME-pg_upgrade=postgresql-pg_upgrade-${VERSION}
> -REVISION-server=0
> +REVISION-server= 1
Namaste Stuart,
Thank you for the patch.
Would it be preferable to remove the extra space after the equal sign in
the REVISION-server line above?
>
> CATEGORIES= databases
> SHARED_LIBS= ecpg 7.10 \
> Index: pkg/README-server
> ===================================================================
> RCS file: /cvs/ports/databases/postgresql/pkg/README-server,v
> retrieving revision 1.28
> diff -u -p -r1.28 README-server
> --- pkg/README-server 9 Feb 2020 09:38:45 -0000 1.28
> +++ pkg/README-server 11 Feb 2020 20:57:45 -0000
> @@ -131,7 +131,12 @@ to the current version.
> "cp /var/postgresql/data-${PREV_MAJOR}/server.{crt,key}
> /var/postgresql/data/"
>
> Some postgresql.conf settings changed or disappeared in this version.
> -Examine your old file for local changes and apply them to the new version.
> +Examine your old file for local changes and apply them to the new version
> +(/var/postgresql/data/postgresql.conf). The following command may help
> +identify them:
> +
> +# diff -wu
> ${LOCALBASE}/share/postgresql-${PREV_MAJOR}/postgresql.conf.sample \
> + /var/postgresql/data-${PREV_MAJOR}/postgresql.conf
>
> 7) Start PostgreSQL:
> # rcctl start postgresql
Dhanyavaad,
ab
---------|---------|---------|---------|---------|---------|---------|--
