On 2020/02/02 11:18, Greg Steuck wrote:
> I tested this with emacs and xterm on amd64-current.
> 
> Add JetBrainsMono fonts port
> ---
>  fonts/Makefile                 |  1 +
>  fonts/jetbrains-mono/Makefile  | 28 ++++++++++++++++++++++++++++
>  fonts/jetbrains-mono/distinfo  |  2 ++
>  fonts/jetbrains-mono/pkg/DESCR |  8 ++++++++
>  fonts/jetbrains-mono/pkg/PLIST | 11 +++++++++++
>  5 files changed, 50 insertions(+)
>  create mode 100644 fonts/jetbrains-mono/Makefile
>  create mode 100644 fonts/jetbrains-mono/distinfo
>  create mode 100644 fonts/jetbrains-mono/pkg/DESCR
>  create mode 100644 fonts/jetbrains-mono/pkg/PLIST

tars are preferred for new ports.

> 
> diff --git a/fonts/Makefile b/fonts/Makefile
> index b3152654cf7..ac33b3811fb 100644
> --- a/fonts/Makefile
> +++ b/fonts/Makefile
> @@ -45,6 +45,7 @@
>       SUBDIR += ja-funetfonts
>       SUBDIR += ja-kanjistrokeorders-ttf
>       SUBDIR += ja-sazanami-ttf
> +     SUBDIR += jetbrains-mono
>       SUBDIR += jmk-fonts
>       SUBDIR += junicode
>       SUBDIR += ko-baekmuk-fonts
> diff --git a/fonts/jetbrains-mono/Makefile b/fonts/jetbrains-mono/Makefile
> new file mode 100644
> index 00000000000..088bd423deb
> --- /dev/null
> +++ b/fonts/jetbrains-mono/Makefile
> @@ -0,0 +1,28 @@
> +# $OpenBSD$
> +
> +COMMENT=        the free and open-source typeface for developers

spaces/tabs problems (unsure if that's just in the diff or in your Makefile),

"the" implies it's the only one? perhaps use something like "monospace typeface
for developers"?

> +
> +DISTNAME=        JetBrainsMono-1.0.2
> +CATEGORIES=        fonts x11
> +
> +HOMEPAGE=        https://jetbrains.com/mono/
> +
> +PERMIT_PACKAGE=        Yes

needs a license marker.

> +
> +MASTER_SITES=        https://download.jetbrains.com/fonts/
> +
> +BUILD_DEPENDS=        archivers/unzip
> +
> +NO_BUILD=        Yes
> +NO_TEST=        Yes
> +PKG_ARCH=        *
> +
> +DISTFILES=        JetBrainsMono-1.0.2.zip
> +
> +INST_DIR=        ${PREFIX}/share/fonts/JetBrainsMono
> +
> +do-install:
> +    ${INSTALL_DATA_DIR} ${INST_DIR}
> +    ${INSTALL_DATA} ${WRKSRC}/ttf/*.ttf ${INST_DIR}

rather than setting DISTFILES it should use EXTRACT_SUFX. lowercase packagename 
is
preferred. you could do e.g.

DISTNAME=       JetBrainsMono-1.0.2
EXTRACT_SUFX=   .zip
PKGNAME=        ${DISTNAME:L}

or something like this so the package name matches the dir name better:

V=              1.0.2
DISTNAME=       JetBrainsMono-$V
EXTRACT_SUFX=   .zip
PKGNAME=        jetbrains-mono-$V

Reply via email to