On Wed, Jan 22, 2020 at 01:53:35PM +0000, Stuart Henderson wrote:
> On 2020/01/22 08:20, mbsd wrote:
> > ping? 
> 
> That is a very short time for sending a "ping" mail ...

Stuart, I'm sorry for the anxiety! 

> - use share/doc/mongo-c-driver instead of share/mongo-c-driver
OK 
> - for the SSL_OP_NO_RENEGOTIATION patch, definitely don't just comment it
> out. either add a !defined(LIBRESSL_VERSION) check or use
> 
>  #ifdef SSL_OP_NO_RENEGOTIATION
>     ssl_ctx_options |= SSL_OP_NO_RENEGOTIATION;
>  #endif
OK 
> - CATEGORIES=databases would be better
OK 
> - don't use -DCMAKE_BUILD_TYPE=Release this is set automatically
OK 

New attachment with corrections.

Attachment: mongo-c-driver.tgz
Description: application/tar-gz

Reply via email to