I was told that simple diffs for existing ports were preferred. Are the two deleted patches still handled appropriately like this? - patch-src_player_c - patch-src_player_h
cvs server: Diffing audio/pianobar Index: audio/pianobar/Makefile =================================================================== RCS file: /cvs/ports/audio/pianobar/Makefile,v retrieving revision 1.88 diff -u -p -u -r1.88 Makefile --- audio/pianobar/Makefile 12 Jul 2019 20:43:39 -0000 1.88 +++ audio/pianobar/Makefile 15 Dec 2019 20:00:41 -0000 @@ -2,8 +2,8 @@ COMMENT = command-line client for Pandora Internet Radio -DISTNAME = pianobar-2017.08.30 -REVISION = 1 +DISTNAME = pianobar-2019.02.14 +REVISION = 0 EXTRACT_SUFX = .tar.bz2 CATEGORIES = audio @@ -11,7 +11,7 @@ HOMEPAGE = https://6xq.net/pianobar/ MASTER_SITES = ${HOMEPAGE} -SHARED_LIBS = piano 9.0 # 0.0.0 +SHARED_LIBS = piano 10.0 # 0.0.0 # MIT PERMIT_PACKAGE = Yes Index: audio/pianobar/distinfo =================================================================== RCS file: /cvs/ports/audio/pianobar/distinfo,v retrieving revision 1.35 diff -u -p -u -r1.35 distinfo --- audio/pianobar/distinfo 31 Aug 2017 09:12:36 -0000 1.35 +++ audio/pianobar/distinfo 15 Dec 2019 20:00:41 -0000 @@ -1,2 +1,2 @@ -SHA256 (pianobar-2017.08.30.tar.bz2) = 7BTbbPGn28HYGQtcoNJWAh6XBYe82usjkE1LynGgRnQ= -SIZE (pianobar-2017.08.30.tar.bz2) = 46664 +SHA256 (pianobar-2019.02.14.tar.bz2) = wL0DE7MUku0mbRky0xnP4qS+cCRoZJLEWLteTOsO4h8= +SIZE (pianobar-2019.02.14.tar.bz2) = 48396 cvs server: Diffing audio/pianobar/patches cvs server: cannot find audio/pianobar/patches/patch-src_player_c cvs server: cannot find audio/pianobar/patches/patch-src_player_h cvs server: Diffing audio/pianobar/pkg Index: audio/pianobar/pkg/PLIST =================================================================== RCS file: /cvs/ports/audio/pianobar/pkg/PLIST,v retrieving revision 1.7 diff -u -p -u -r1.7 PLIST --- audio/pianobar/pkg/PLIST 10 Jan 2017 12:46:41 -0000 1.7 +++ audio/pianobar/pkg/PLIST 15 Dec 2019 20:00:41 -0000 @@ -1,7 +1,7 @@ -@comment $OpenBSD: PLIST,v 1.7 2017/01/10 12:46:41 sthen Exp $ +@comment $OpenBSD: PLIST,v$ @bin bin/pianobar include/piano.h -lib/libpiano.a +@static-lib lib/libpiano.a @lib lib/libpiano.so.${LIBpiano_VERSION} @man man/man1/pianobar.1 share/examples/pianobar/ On Sat, Dec 14, 2019 at 9:09 AM Brad DeMorrow <[email protected]> wrote: > Changes gleaned from release commit history: > - Add network timeouts and retries > - Fix cross-thread memory access > - Misc UI and documentation improvements > - Implement audio buffering > - Fix MP3 playback (affects premium subscribers with audio quality “high”) > > Port Changes: > - Custom patches were removed that are no longer needed. > - SHARED_LIBRARY libpiano bumped to 10.0 from 9.0. Nothing > else uses it as far as I'm aware, but I assumed it should be bumped > anyway? > > Consumers: > - A make search key=pianobar reveals no other ports that reference > pianobar. > If there is a better way to check for this, please let me know. > > Tests: > Tested on amd64 only. > I had constant stutter and distorted audio with our version in ports. > This update seems to have fixed those issues. > > -- --Brad DeMorrow
