On Fri, Nov 29, 2019 at 02:19:06PM +0300, Kirill Bychkov wrote: > On Thu, November 28, 2019 18:56, Landry Breuil wrote: > > On Thu, Nov 28, 2019 at 04:10:11PM +0100, clematis wrote: > >> On Thu, Nov 28, 2019 at 03:38:23PM +0100, Landry Breuil wrote: > >> > Feels wrong here, if you want to remove patches you should cvs rm them > >> > so that they show up as removed in your cvs diff. Right now, the patches > >> > arent removed, so make patch fails. > >> > > >> > I see that patch-src_window_c & patch-src_layout_util_c apply fine and > >> > patch-Makefile_am fails on a chunk. Were you planning to remove those > >> > patches ? Why ? Are they not useful anymore (unsure for the src/window.c > >> > one..) ? > >> > >> Argh, sorry I might have generate the previous diff from a working dir > >> or don't know how I skipped diffing patches/ > >> > >> Here's a new one attached which I double checked so that should be the > >> last one ! Sorry about that. > > > > I have it building here, but it seems configure checks for poppler-glib > > and links with it if found, thus port-lib-depends-check complains about > > it: > > > > geeqie-1.5.1v0(graphics/geeqie): > > Missing lib: poppler-glib.19 (/usr/local/bin/geeqie) (NOT REACHABLE) > > > > looking at upstream repository on > > http://geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=history;f=configure.ac > > it looks like they added support for webp, pdf, lua, djvu, openjp2, etc - > > you > > might want to add those are dependencies, or explicitely disable them. > > > > Landry > > > > > > Hi! > Tweaked diff attached with pdf disabled. djvu and lua are already disabled. > Can't find any knobs about webp and openjp2.
Right, those were added post-1.5.1, so something to keep in mind for future releases. > Works fine for me on amd64. ok with me; thanks !
