On 22/11/2019 12:53, Stuart Henderson wrote:
- use portcheck! - typing-extensions and zipp are backports of features that are already in the version of Python that we have in ports, so shouldn't be imported - "# python3 tests require py-flake8-* ports" -> flake8 is in devel/flake8. - various pkg/DESCR are poor (yes I know upstream's are also poor but that's no reason for ours to be) or completely wrong (e.g. zipp's is copied from typing-extensions) - mixed whitespace in Makefiles, missing rcsids, bad COMMENT formatting - please include a user.list diff if sending a port with @newuser - is there anything that can be done about the generic filenames in /usr/local/bin? bin/generate_config bin/generate_signing_key.py bin/hash_password bin/move_remote_media_to_new_store.py bin/register_new_matrix_user bin/synapse_port_db bin/sync_room_to_group.pl bin/synctl
Here is an updated version, taking into account your remarks. Except the typing-extensions, which seems to be required for this version.
synapse.tgz
Description: GNU Zip compressed data
Index: user.list =================================================================== RCS file: /cvs/ports/infrastructure/db/user.list,v retrieving revision 1.354 diff -u -p -r1.354 user.list --- user.list 4 Oct 2019 20:30:27 -0000 1.354 +++ user.list 22 Nov 2019 17:20:18 -0000 @@ -353,3 +353,4 @@ id user group port options 842 _e2guardian _e2guardian www/e2guardian 843 _dkimsign _dkimsign mail/opensmtpd-filters/dkimsign 844 _routinator _routinator net/routinator +845 _synapse _synapse net/synapse
