On Fri Nov 15, 2019 at 07:47:32PM +0300, Kirill Bychkov wrote:
> On Fri, November 15, 2019 19:37, Giovanni Bechis wrote:
> > On 11/15/19 4:08 PM, Kirill Bychkov wrote:
> >> On Fri, November 8, 2019 16:15, Adriano Barbosa wrote:
> >>> Em sex., 8 de nov. de 2019 ?s 09:32, Kirill Bychkov
> >>> <[email protected]> escreveu:
> >>>>
> >>>> On Fri, November 8, 2019 12:32, Adriano Barbosa wrote:
> >>>>> By the way, Kirill's suggestions are ok for me. Just compiled it
> >>>>> without problems.
> >>>>>
> >>>>> Best
> >>>>>
> >>>>> Em sex., 8 de nov. de 2019 ?s 06:03, Adriano Barbosa
> >>>>> <[email protected]> escreveu:
> >>>>>>
> >>>>>> Hi Kirill,
> >>>>>> thank you for your test and suggestions.
> >>>>>> error: use of undeclared identifier 'EVP_PKEY_CTX_set_rsa_oaep_md' is
> >>>>>> related to LibreSSL. Are you running -current?
> >>>>>> My original port had a patch for it, but its not necessary anymore in
> >>>>>> -current.
> >>>>
> >>>> My -current was two weeks old, sorry. Now it builds fine.
> >>>> Not tested yet.
> >>>>
> >>>> owncloudclient has 40 test and one is failing (FolderWatcherTest).
> >>>> nextcloudclient has 35 tests and four of them are failing:
> >>>> 12 - UtilityTest (Failed)
> >>>> 19 - AllFilesDeletedTest (Failed)
> >>>> 33 - check_vio_ext (Failed)
> >>>> 35 - check_encoding_functions (Failed)
> >>>> All of them passes in owncloudclient.
> >>>
> >>> I'm trying to learn as much as I can from this porting process and
> >>> tests using cmake/cmocka are part of my ignorance. I found 25 binaries
> >>> related to tests in ${WRKSRC}/nextcloudclient-2.6.1/build-amd64/bin
> >>> after building the port. None of them fails, including
> >>> AllFilesDeletedTest and UtilityTest, log attached, didn't find the
> >>> other two tests you pointed out. I would be very happy if you could
> >>> point out something for me to read about it.
> >>
> >> We can deal with the tests later. Nextcloudclient works fine for me
> >> with my owncloud server. It even works better than owncloudclient
> >> I'm maintaining. It syncs all my files without errors. With
> >> owncloudclient I have to add more and more files to exclude list
> >> because it fails.
> >> Attached is updated tarball with more tweaks:
> >> - add COMPILER and comment because of c++14
> >> - pre-configure -> post-extract
> >> - saet SYSCONF_INSTALL_DIR similar to owncloudclient
> >> - fix typos in post-extract comment
> >> - use post-install target for dance with global exclude list (same
> >> as in owncloudclient)
> >> Changes for config file were needed because previous version of port
> >> errors immediately after finishing setup wizard complaining that global
> >> exclude file couldn't be found.
> >> Currently it works for me. I want to test fresh install to be sure it
> >> will work fine.
> >>
> > Bogus WANTLIB: inotify.2 (/usr/local/lib/libnextcloudsync.so.0.0) (NOT
> > REACHABLE)
>
> That's normal for all ports linking with inotify.
>
> >
> > at runtime I have the error:
> > could not read system exclude file
> >
> > doas mkdir /etc/Nextcloud && doas cp
> > /usr/obj/ports/nextcloudclient-2.6.1/desktop-2.6.1/sync-exclude.lst
> > /etc/Nextcloud
> > fixes the problem.
>
> Thanks for testing. So the last tweak we need is to add a couple of
> @sample lines.
> Updated tarball attached.
>
> >
Small tweaks:
- Fix spaces, tabs
- Remove COMPILER because it comes from qt5
Optional: I would prefer "desktop sync client for Nextcloud" as COMMENT.
With this two tweaks + optional comment, OK rsadowski@ to import it.
--- Makefile.orig Fri Nov 15 22:05:27 2019
+++ Makefile Fri Nov 15 22:11:04 2019
@@ -1,13 +1,13 @@
# $OpenBSD: Makefile.template,v 1.85 2019/09/09 19:19:05 kmos Exp $ #
-COMMENT = nextcloud sync client
+COMMENT = desktop sync client for Nextcloud
V = 2.6.1
DISTNAME = nextcloudclient-${V}
-GH_ACCOUNT = nextcloud
-GH_PROJECT = desktop
-GH_TAGNAME = v${V}
+GH_ACCOUNT = nextcloud
+GH_PROJECT = desktop
+GH_TAGNAME = v${V}
CATEGORIES = net
@@ -27,9 +27,6 @@ WANTLIB += sqlite3 ssl z lib/inotify/inotify
MODULES = devel/cmake \
x11/qt5
-
-# C++14
-COMPILER = base-clang ports-gcc
BUILD_DEPENDS = devel/gettext,-tools
