On 2019/11/01 14:56, Lucas Raab wrote:
> On Thu, Oct 31, 2019 at 09:33:11PM +0100, Klemens Nanni wrote:
> > On Sun, Oct 27, 2019 at 04:37:42PM -0400, Kurt Mosiejczuk wrote:
> > > With these changes, OK kmos@
> > Looks good, a few things:
> >
> > Not sure how this library fits into sysutils as secondary category,
> > devel would fit after security, though.
>
> That's fine with me, I'll make the update.
I'd just drop thd second category, devel is rwally "ports to help
woth software development, plus random things where we ckuldn't find
a better category". It doesn't make ot any easier to find this.
> > setup.py lists
> > 61 extras_require={':python_version < "3.4"': ["enum34"], "pcsc":
> > ["pyscard"]},
> >
> > That's still unaccounted for.
> >
> > DESCR could contain more from ${WRKSRC}/README.adoc though.
> >
> > Besides BSD, this port ships code under APL 2.0 and MPL 2.0 as well, see
> > the readme file.
> >
> > Perhaps the example files are worth shipping as well?
> >
> > OK kn with the py-enum34 dependency fixed, the rest I'll leave to
> > whoever commits (and maintains) this port - they're mere impressions
> > after a quick look.
>
> All other updates have been made. It's also a Python 3 only package
> based on the feedback from yourself and sthen about the py-scard
> packge depending on the Python 3-only pcsc-lite
enum34 should *not* be listed, it is only for python 3.3 and lower.
