On Mon, Aug 12, 2019 at 09:04:09PM -0400, Kurt Mosiejczuk wrote: > On Mon, Aug 12, 2019 at 08:03:16PM -0400, Kurt Mosiejczuk wrote: > > On Mon, Aug 12, 2019 at 06:44:46PM -0400, Daniel Jakots wrote: > > > On Mon, 12 Aug 2019 18:32:16 -0400, Kurt Mosiejczuk <[email protected]> > > > wrote: > > > > > +FLAVORS= python3 > > > > +FLAVOR?= > > > > Isn't it just a tool? Maybe it's more meaningful to just provide a py3 > > > version. What's your opinion? > > > That is actually an excellent point. It had been python 2 only so I was > > more concerned with adding python3. > > > Actually, going one flavor is required as it is. It installs plain binaries > > (xmldiff, xmlpatch) and I didn't throw a suffix on them. > > > I'll rework it to be python3 only and then have a quirks diff to migrate > > folks from py-xmldiff to py3-xmldiff. > > Here's a new version of the diff making it python3 only. I'm also including > a quirks diff at the end that will migrate folks from py-xmldiff to > py3-xmldiff.
Reads good to me, and i also agree with the move to py3 only. thanks ! Landry
