On 2019/08/08 12:08, Kurt Mosiejczuk wrote:
> This adds MODPY_EGG_VERSION, MODPY_PI, MODPY_SETUPTOOLS, and
> MODPY_VERSION to /usr/ports/infrastructure/templates/Makefile.template.
>
> These are the most common entries that portgen(1) will throw at the
> bottom of a generated python port because it doesn't know where it would
> go. Adding these lines should put them in the appropriate place.
Good additions, one nit:
> --Kurt
>
> Index: Makefile.template
> ===================================================================
> RCS file: /cvs/ports/infrastructure/templates/Makefile.template,v
> retrieving revision 1.83
> diff -u -p -r1.83 Makefile.template
> --- Makefile.template 2 Jul 2019 12:03:14 -0000 1.83
> +++ Makefile.template 8 Aug 2019 16:05:48 -0000
> @@ -18,6 +18,11 @@ COMMENT = ???
> # COMMENT-foo = ??? for multi packages
>
> #
> +# Version of port if using lang/python module
> +#
> +#MODPY_EGG_VERSION = ???
> +
> +#
> # What port/package will be created
> #
> DISTNAME = ???
> @@ -102,8 +107,17 @@ MASTER_SITES = ???
> # Ports that require a non-default compiler that do *not* use C++ should set
> this:
> #COMPILER_LANGS = c
>
> -# Dependencies
> +# Any modules we may be using
> #MODULES = ???
> +
> +#
> +# MODPY_ settings for when using lang/python module
> +#
> +#MODPY_PI = Yes # Get source from pypi.org
> +#MODPY_SETUPTOOLS = Yes
> +#MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3} # If port is python3 only
I'd prefer to have the comments on a separate line. If you want to
uncomment the line to enable it it's easier to just delete a line,
rather than move to the correct column and delete to end of line.
Otherwise I just know someone is going to /#[enter]C[esc] and
leave the trailing whitespace which make(1) doesn't strip from the
variable :-)
> +
> +# Dependencies
> #BUILD_DEPENDS = ???
> #RUN_DEPENDS = ???
> #LIB_DEPENDS = ???
>
