On Sun, Jul 21, 2019 at 03:17:33PM +0200, Caspar Schutijser wrote:
> On Sun, Jul 21, 2019 at 02:02:00PM +0200, Landry Breuil wrote:
> > On the diff itself, dependency between py- and the lib should be
> > enforced, otherwise you get this:
> >
> > Error: QScintilla 2.10.1 is being used but the Python bindings 2.11.2
> > are being built. Please use matching versions.
> >
> > LIB_DEPENDS = editors/qscintilla,qt5>=2.11.2 (and its equivalent for the
> > default FLAVOR, and maybe even = and not >= ) in py-qscintilla Makefile
> > does the trick.
> >
> > Landry
>
> That's a very good point indeed, thank you. Below is a diff that
> addresses your feedback. I choose to depend on
> editors/qscintilla,qt5=${VERSION} so those lines doesn't have to be
> adjusted with every update.
qgis 3.8 is happy at runtime with this update, so this update is ok for
me if anyone plans to commit it.
Landry