On Thu, Jun 20 2019, Giovanni Bechis <[email protected]> wrote:
> Hi,
> I was going to update mail/courier-authlib but I found that, even the version
> we have in tree, gives an error make lib-depends-check:
>
> courier-authlib-0.68.0p5(mail/courier-authlib,-main):
> Missing: z.5 (/usr/local/lib/libauthsqlite.so.0.0) (system lib)
> Extra: iconv.6 idn.18 intl.6
> WANTLIB += z
>
> courier-authlib-mysql-0.68.0p3(mail/courier-authlib,-mysql):
> Missing: iconv.6 from libiconv-1.14p3 (/usr/local/lib/libauthmysql.so.0.0)
> Missing: mariadb.28 from mariadb-client-10.3.15v1
> (/usr/local/lib/libauthmysql.so.0.0)
> Extra: mysqlclient.28
> WANTLIB += iconv mariadb
>
> The second one depends on databases/mariadb update and it's easily fixable
> but what about the first one ?
> Should I remove gettext,-runtime and libidn from dependencies ? I am not sure
> this
> is the way to go.
This:
--8<--
# statically linked
WANTLIB-main+= iconv idn intl
LIB_DEPENDS-main+= devel/gettext \
devel/libidn
-->8--
was added by sthen in
--8<--
revision 1.66
date: 2017/08/15 11:11:40; author: sthen; state: Exp; lines: +8 -4;
commitid: vmUiQQV4Jazzk0G7;
Add missing devel/libidn dependency. List the statically linked libraries
in WANTLIB+LIB_DEPENDS with a warning comment, to encourage pkg_add to update
courier-authlib when there are changes to the libs. ok giovanni@ (maintainer)
-->8--
IIUC libidn is only used by librfc822.a, which in turn is only used
to statically compile the "reftest" and "testsuite" tests. Neither this
static library nor said programs are installed, so I'd suggest to remove
gettext from deps (it isn't directly used), moving libidn to
BUILD_DEPENDS and amending WANTLIB-main.
Stuart, what do you think?
By the way, I'm not sure the intltool module is needed either.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
