On 2019/06/14 13:16, Raphael Graf wrote:
> The change history is listed on this page:
> https://soundtouch.surina.net/README.html
>
> Some of the changes look interesing, for example:
> - Fixed potential buffer overwrite bugs in WavFile routines.
> - Rewrote Beats-per-Minute analysis algorithm for more reliable BPM detection
> - Fixed issue that added brief sequence of silence to beginning of output
> audio
>
> I have compile-tested the following ports:
> - audio/audacity
> - emulators/citra
> - emulators/desmume
> - multimedia/gstreamer-0.10/plugins-bad
> - multimedia/gstreamer1/plugins-bad
>
> It works fine on amd64 and macppc.
>
> Any comments or ok?
>
The patched files have MS-DOS line endings, could you fix those up in
post-extract and regen patches please? Here is one method:
post-extract:
@cd ${WRKSRC} && perl -i -pe 's/\r$$//' [whatever files]
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/audio/soundtouch/Makefile,v
> retrieving revision 1.24
> diff -u -p -u -p -r1.24 Makefile
> --- Makefile 24 Oct 2018 14:27:58 -0000 1.24
> +++ Makefile 14 Jun 2019 11:07:44 -0000
> @@ -2,17 +2,17 @@
>
> COMMENT= tempo/pitch audio processing library
>
> -DISTNAME= soundtouch-1.9.2
> -SHARED_LIBS += SoundTouch 3.0 # .0.0
> +V= 2.1.2
> +DISTNAME= soundtouch-${V}
> +SHARED_LIBS= SoundTouch 4.0
> CATEGORIES= audio devel
> -REVISION = 3
>
> -HOMEPAGE= http://www.surina.net/soundtouch/
> +HOMEPAGE= https://www.surina.net/soundtouch/
>
> # LGPLv2.1+
> PERMIT_PACKAGE_CDROM= Yes
>
> -MASTER_SITES= ${HOMEPAGE}
> +MASTER_SITES= https://gitlab.com/soundtouch/soundtouch/-/archive/${V}/
>
> WANTLIB= c m ${COMPILER_LIBCXX}
>
> @@ -22,10 +22,8 @@ BUILD_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS
> ${MODGNU_AUTOMAKE_DEPENDS} \
> devel/libtool
>
> -WRKDIST= ${WRKDIR}/soundtouch
> -
> -AUTOCONF_VERSION=2.61
> -AUTOMAKE_VERSION=1.9
> +AUTOCONF_VERSION=2.69
> +AUTOMAKE_VERSION=1.16
>
> CONFIGURE_STYLE=gnu
> CONFIGURE_ARGS= --disable-x86-optimizations
> @@ -36,10 +34,11 @@ MAKE_FLAGS= AUTOCONF_VERSION=${AUTOCONF_
>
> pre-configure:
> cd ${WRKSRC} && \
> - touch NEWS README AUTHORS ChangeLog && \
> AUTOCONF_VERSION=${AUTOCONF_VERSION} \
> AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
> PATH=${PORTPATH} \
> ./bootstrap
this can be tidied now;
CONFIGURE_STYLE= autoreconf
AUTORECONF= ./bootstrap
and remove BUILD_DEPENDS and the AUTOxxxx_VERSION bits from MAKE_FLAGS.
> +NO_TEST= Yes
please zap the NO_TEST, that is for "there are no tests and it fails
if you try to run them", but in this case removing the line just does
$ make test
===> Regression tests for soundtouch-2.1.2
Making check in include
Making check in source
Making check in SoundTouch
Making check in SoundStretch
which is fine.
