On Mon, June 10, 2019 16:13, Charlene Wendling wrote: > On Mon, 10 Jun 2019 13:49:49 +0100 > Stuart Henderson wrote: > >> On 2019/06/10 13:22, Charlene Wendling wrote: >> > Hi :) >> > >> > > http://build-failures.rhaalovely.net//powerpc/2019-05-19/graphics/ufraw.log >> > > http://build-failures.rhaalovely.net/aarch64/2019-06-02/graphics/ufraw.log >> > > http://build-failures.rhaalovely.net/arm/last/graphics/ufraw.log >> > >> > It's a typical case of code that assumes that char is signed on all >> > platforms - not much to say. >> > >> > It has been built and tested on macppc [0] and amd64. >> > >> > Comments/feedback are welcome! >> >> OK. The dcraw code is copied around a lot, it maybe worth checking >> others - besides ufraw there are: > > Thanks. > > Yes, we had issues with similar dcraw implementations already. > > Already fixed and tested: >> graphics/freeimage > > Supposedly fixed: >> graphics/rawstudio > > No fixes: >> graphics/dcraw >> graphics/libraw >> graphics/rawtherapee
Hi! rawtherapee is supposed to run only on amd64. Probably it could work well on aarch64 too. > > I'll try to take some time once all the trivial stuff is done and > study them. > >> >> (if they don't fail then maybe they're built with -funsigned-char) >> > > Charl?ne. > >
