On 2019/05/28 00:12, Jeremie Courreges-Anglas wrote:
> Adding aarch64 to GCC49_ARCHS makes sense to me. Renaming GCC49_ARCHS
> to something else can be done in another step. ok jca@
>
> cc'ing bcallah@, pascal@, phessler@ and espie@, maybe I'm missing
> others.
Adding aarch64 to GCC49_ARCHS is clearly correct, ok with me. It shouldn't
change dep's either:
sqlite> select distinct compiler from ports order by compiler;
base-clang
base-clang base-gcc
base-clang base-gcc gcc3
base-clang ports-clang
base-clang ports-clang ports-gcc
base-clang ports-gcc
base-clang ports-gcc base-gcc
base-clang ports-gcc ports-clang
base-gcc ports-gcc
ports-clang
ports-gcc
ports-gcc
> > Index: arch-defines.mk
> > ===================================================================
> > RCS file: /cvs/ports/infrastructure/mk/arch-defines.mk,v
> > retrieving revision 1.64
> > diff -u -p -r1.64 arch-defines.mk
> > --- arch-defines.mk 11 May 2019 12:05:46 -0000 1.64
> > +++ arch-defines.mk 27 May 2019 18:52:04 -0000
> > @@ -36,7 +36,7 @@ LLD_ARCHS = aarch64 amd64 arm i386
> > # as well as available for PROPERTIES checks.
> > LLVM_ARCHS = aarch64 amd64 arm i386 mips64 mips64el powerpc sparc64
> > # arches where gcc4.9 exists. To be used again for modules
I agree with postponing renaming the variable to a separate step.
But to avoid confusion until then, I would also change the comment here,
e.g. something like
"arches where ports gcc exists (XXX any version, not just 4.9)"
> > -GCC49_ARCHS =alpha amd64 arm hppa i386 mips64 mips64el powerpc sparc64
> > +GCC49_ARCHS = aarch64 alpha amd64 arm hppa i386 mips64 mips64el powerpc
> > sparc64
> >
> > # arches where there is a C++11 compiler, either clang in base or gcc4
> > CXX11_ARCHS = ${CLANG_ARCHS} ${GCC49_ARCHS}
> >
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
>
