On Thu, May 16, 2019 at 06:41:06PM -0400, Brian Callahan wrote: > *Please* tell me you're going to send these patches upstream. There's a lot > here and as you say, you're trying to get this into more than just OpenBSD > ports, and your patches do far more than OpenBSD support. >
Yes, I sent these patches to both upstreams. Meanwhile Warsow's new upstream is not collaborative because I used wallhack in the past and because more OS support "is a minor topic that has nothing with actual challenges in the game development": https://github.com/Warsow/qfusion/pull/40#issuecomment-492069962 (at least I got some help from that person before he banned me at his organization) So, I think only qfusion's upstream will accept these patches: https://github.com/Qfusion/qfusion/pull/434 (but I doubt compatibility between qfusion and its fork intended to continue Warsow's development) > I'm slowly going through everything and will write back when I'm finished. > There are definitely some things that need tweaking. > Yeah, I forgot to remove some CFLAGS from CMakeLists.txt when I was sending this port. Also please don't commit this port yes, I will fork this game's release and apply more patches if you notice something wrong or if for some reason I fail to build it at other *BSD, then I'll send this port again ready to be committed. And this fork will let me avoid headaches keeping patches in sync. > ~Brian >
