On Sun, May 05 2019, Raphael Graf <[email protected]> wrote: > Here is an update to hydrogen-0.9.7. > > Notable changes: > - Uses cmake instead of scons. > - There is a shared library and three additional command-line binaries. > - Enabled support for audio/ladspa plugins > > New features are listed here: > http://hydrogen-music.org/ > > Comments/tests welcome.
Here's some nitpicking about the Makefile only. > Index: Makefile > =================================================================== > RCS file: /cvs/ports/audio/hydrogen/Makefile,v > retrieving revision 1.25 > diff -u -p -u -p -r1.25 Makefile > --- Makefile 8 Jan 2019 21:24:29 -0000 1.25 > +++ Makefile 5 May 2019 10:55:31 -0000 > @@ -1,58 +1,54 @@ > # $OpenBSD: Makefile,v 1.25 2019/01/08 21:24:29 sebastia Exp $ > > -COMMENT= software drum machine > +COMMENT = software drum machine Please avoid gratuitous whitespace changes like this, it makes cvs blame less useful for no real gain. If you really care for consistency I'd suggest to tweak the COMPILER line instead. > -DISTNAME= hydrogen-0.9.5 > -CATEGORIES= audio > +DISTNAME = hydrogen-0.9.7 > +CATEGORIES = audio > > -HOMEPAGE= http://www.hydrogen-music.org/ > +HOMEPAGE = http://www.hydrogen-music.org/ > + > +SHARED_LIBS = hydrogen-core-0.9.7 0.0 I'm not saying it's a problem in practice, but this library name looks suspicious... > # GPLv2 > -PERMIT_PACKAGE_CDROM= Yes > +PERMIT_PACKAGE_CDROM = Yes > > -WANTLIB += ${COMPILER_LIBCXX} QtGui QtNetwork QtXml archive c > -WANTLIB += jack lrdf m ogg sndfile sndio > +WANTLIB += ${COMPILER_LIBCXX} QtGui QtNetwork QtXml QtXmlPatterns archive c > +WANTLIB += lrdf m sndfile sndio z > > -MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=hydrogen/} > +MASTER_SITES = ${MASTER_SITE_SOURCEFORGE:=hydrogen/} > > COMPILER = base-clang ports-gcc base-gcc > > -LIB_DEPENDS= audio/libsndfile \ > - audio/flac \ > - audio/jack \ > +LIB_DEPENDS = audio/libsndfile \ > archivers/libarchive \ > textproc/liblrdf > > -RUN_DEPENDS= devel/desktop-file-utils > +BUILD_DEPENDS = audio/ladspa > + > +RUN_DEPENDS = devel/desktop-file-utils > > -MODULES= x11/qt4 devel/scons > +MODULES = devel/cmake x11/qt4 I would suggest splitting MODULES over multiple lines. Note: looks like hydrogen-1.0.0 will support Qt5. > -MAKE_ENV+= QTDIR="${MODQT4_QTDIR}" > -MODSCONS_FLAGS= localinc="-I${LOCALBASE}/include > -I${X11BASE}/include" \ > - locallib="-L${LOCALBASE}/lib -L${X11BASE}/lib -logg > -lpthread" \ > - optflags="${CXXFLAGS} " \ > - libarchive="1" sndio="1" oss="0" alsa="0" portmidi="0" \ > - portaudio="0" lash="0" lrdf="1" > +CONFIGURE_ENV = LADSPA_PATH=${LOCALBASE}/lib/ladspa > > -NO_TEST= Yes > +CONFIGURE_ARGS = -DWANT_ALSA=OFF \ > + -DWANT_DEBUG=OFF \ > + -DWANT_JACK=OFF \ > + -DWANT_JACKSESSION=OFF \ > + -DWANT_LADSPA=ON \ > + -DWANT_LRDF=ON \ > + -DWANT_NSMSESSION=OFF \ > + -DWANT_PORTAUDIO=OFF \ > + -DWANT_PORTMIDI=OFF \ > + -DWANT_PULSEAUDIO=OFF \ > + -DWANT_SNDIO=ON > + > +NO_TEST = Yes > > post-extract: > cp ${FILESDIR}/Sndio{Audio,Midi}Driver.h \ > - ${FILESDIR}/sndio_{audio,midi}_driver.cpp \ > - ${WRKSRC}/libs/hydrogen/src/IO > - > -do-install: > - ${INSTALL_PROGRAM} ${WRKBUILD}/hydrogen ${PREFIX}/bin > - ${INSTALL_DATA_DIR} ${PREFIX}/share/applications > - ${INSTALL_DATA} ${WRKBUILD}/hydrogen.desktop \ > - ${PREFIX}/share/applications > - ${INSTALL_DATA_DIR} ${PREFIX}/share/pixmaps > - ${INSTALL_DATA} ${WRKSRC}/data/img/gray/h2-icon.svg \ > - ${PREFIX}/share/pixmaps > - ${INSTALL_DATA_DIR} ${PREFIX}/share/hydrogen > - ${INSTALL_DATA_DIR} ${PREFIX}/share/hydrogen/data > - #mv -f ${WRKSRC}/data/new_tutorial ${WRKDIR} > - cd ${WRKSRC}/data && umask 022 && \ > - pax -rw . ${PREFIX}/share/hydrogen/data > + ${WRKSRC}/src/core/include/hydrogen/IO > + cp ${FILESDIR}/sndio_{audio,midi}_driver.cpp \ > + ${WRKSRC}/src/core/src/IO > > .include <bsd.port.mk> -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
