On 2019/04/24 14:21, Daniel Jakots wrote:
> On Tue, 23 Apr 2019 13:55:33 +0100, Stuart Henderson
> <[email protected]> wrote:
>
> > I haven't gone through any testing with these yet, but if anyone
> > wants to help prepare for python 3.7 then testing these with
> > dependencies (with the in-tree Python versions) would be helpful.
> >
> > databases/py-psycopg2/Makefile
>
> ok
Thanks. Will wait a couple of days for shadchin@.
> > www/py-aiohttp/Makefile
>
> You're missing some rdep and we don't package some tests so NO_TEST is
> needed. Diff attached to fix, with my diff applied, ok
Thanks, committed.
> > www/py-gunicorn/Makefile
>
> comments inlined + diff attached
> with my diff applied, ok
>
> > www/py-tornado/Makefile
>
> I haven't looked at it
>
>
> > Index: www/py-gunicorn/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/www/py-gunicorn/Makefile,v
> > retrieving revision 1.20
> > diff -u -p -r1.20 Makefile
> > --- www/py-gunicorn/Makefile 4 May 2018 11:37:24 -0000
> > 1.20 +++ www/py-gunicorn/Makefile 20 Apr 2019 10:10:12 -0000
> > @@ -2,7 +2,7 @@
> >
> > COMMENT = Python WSGI HTTP server
> >
> > -MODPY_EGG_VERSION = 19.8.1
> > +MODPY_EGG_VERSION = 19.9.0
> > DISTNAME = gunicorn-${MODPY_EGG_VERSION}
> > PKGNAME = py-${DISTNAME}
> > CATEGORIES = www
> > @@ -25,7 +25,8 @@ RUN_DEPENDS += www/py-aiohttp \
> > www/py-multidict
> > .endif
> > TEST_DEPENDS = devel/py-test${MODPY_FLAVOR} \
> > - devel/py-test-cov${MODPY_FLAVOR}
> > + devel/py-test-cov${MODPY_FLAVOR} \
> > + ${BASE_PKGPATH}=${MODPY_EGG_VERSION}
>
> for psycopg2, you used ${FULLPKGNAME}:${BUILD_PKGPATH}, what's the
> difference?
Cargo culted from different ports, we have quite a few different ways
to handle this situation ..
>
> You're missing a tdep on py-coverage and while their check was ok
> during last gunicorn update, we updated py-coverage and now we're
> outside the bound so we need to remove the check in
> patches/patch-requirements_test_txt
Thanks, applied.
