On Fri, Mar 01, 2019 at 11:17:48AM +0100, Hiltjo Posthuma wrote:
> - Respect system LDFLAGS.
> - Use the main releases location (2f30 is a mirror).
> - Remove now unneeded config.mk patch: stagit now checks #ifdef __OpenBSD__
> for pledge(2).
Thanks, I'll commit soon. Two things, though:
> MAKE_FLAGS= CC='${CC}' \
> - CFLAGS='${CFLAGS}' \
> - COMPATOBJ='' \
> - GITINC=${LOCALBASE}/include \
> - GITLIB=${LOCALBASE}/lib
> + CFLAGS="${CFLAGS} -I${LOCALBASE}/include" \
> + LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib -lgit2" \
> + COMPATOBJ=''
I'd go with all single quotes here for consistency (with CC='${CC}').
> --- a/www/stagit/pkg/PLIST
> +++ b/www/stagit/pkg/PLIST
> @@ -3,10 +3,10 @@
> @bin bin/stagit-index
> @man man/man1/stagit-index.1
> @man man/man1/stagit.1
> -share/stagit/
> -share/stagit/README
> -share/stagit/example_create.sh
> -share/stagit/example_post-receive.sh
> -share/stagit/favicon.png
> -share/stagit/logo.png
> -share/stagit/style.css
> +share/doc/stagit/
> +share/doc/stagit/README
This is documentation,
> +share/doc/stagit/example_create.sh
> +share/doc/stagit/example_post-receive.sh
these are examples,
> +share/doc/stagit/favicon.png
> +share/doc/stagit/logo.png
> +share/doc/stagit/style.css
those as well, but I'd count them as static files, too.
Not sure how much I'm nitpicking here, but what about using the
appropiate directories as per our porters guide?
read-only architecture-independent: /usr/local/share/<name>
misc documentation: /usr/local/share/doc/<name>
examples files: /usr/local/share/examples/<name>
