On 2019/03/07 07:05, Björn Ketelaars wrote:
> Diff below brings miniupnpc to the latest version (2.1). Changelog can
> be found at
> http://miniupnp.free.fr/files/changelog.php?file=miniupnpc-2.1.tar.gz
>
> Major of SHARED_LIB has been bumped as symbols have been removed.
> Removed python multipackage as there are no ports that depend on it.
Consumers will need REVISION bumps due to the pkgpath change.
> Build tested its consumers, and run tested against miniupnpd.
The rest looks good and if nobody objects to removing py-miniupnpc
then removing the python bits simplifies the port a lot.
One other comment, though it's not new:
> +WANTLIB += c
>
> USE_GMAKE= Yes
> MAKE_ENV= APIVERSION=${LIBminiupnpc_VERSION} \
If you pass APIVERSION in via MAKE_FLAGS instead of MAKE_ENV ....
> @@ -32,21 +14,7 @@ MAKE_ENV= APIVERSION=${LIBminiupnpc_VERS
<snip>
> -$OpenBSD: patch-Makefile,v 1.5 2018/12/08 22:11:40 ajacoutot Exp $
> ---- Makefile.orig Fri Jan 31 14:57:23 2014
> -+++ Makefile Mon Feb 3 12:26:26 2014
> -@@ -55,7 +55,7 @@ ifeq (SunOS, $(OS))
> +$OpenBSD: patch-Makefile,v 1.5 2018/12/08 22:11:40 ajacoutot Exp $ Index:
> Makefile
> +Index: Makefile
> +--- Makefile.orig
> ++++ Makefile
> +@@ -69,7 +69,7 @@ ifneq (, $(findstring sun, $(OS)))
> endif
>
> # APIVERSION is used to build SONAME
> --APIVERSION = 10
> -+APIVERSION ?= 10
> +-APIVERSION = 17
> ++APIVERSION ?= 17
.... you can likely get rid of this part of the patch ^^
