On Tue, Mar 05, 2019 at 09:57:13PM +0100, Landry Breuil wrote:
> On Tue, Mar 05, 2019 at 11:18:56AM +0100, Martin Reindl wrote:
> > [...]
>
> So, comments portswise:
> - no need for DIST_SUBDIR=${DISTNAME} (remember to regen distinfo)
> - no need for the complicated DISTNAME/DISTFILES/WRKDIST dance
>
> DISTNAME = ${NAME}-c-${V}
> PKGNAME = ${NAME}-${V}
>
> is enought and seems to work fine here
>
> - i think you forgot to cvs rm patch-cxx_ncvalues_cpp &
> patch-ncgen_ncgen_1 in your diff :)
> - all tests indeed pass, testing on non-x86 would be nice.
> - major should probably be bumped as its a major version
>
> and what matters for me, i can build MDAL fine with this update.
> let's hear what MAINTAINER thinks about it.. maybe the c++ & fortran bits
> should be ported too, but if nothing needs them.. .
These are all very valid points, I will consider on my way to py-pvlib. netcdf
these days is split up among at least 6 different projects (netcdf-c, netcdf-f
netcdf-c++, netcdf-java, cftime, py-netcdf). Fortunately all from the same
company.
-m
