On 2019/03/04 09:40, Olivier Taïbi wrote: > Thanks for your advice! I confirmed that old zathura still works with > updated girara, so no major bump is needed. > > On Mon, Mar 04, 2019 at 02:31:17AM +0100, Jeremie Courreges-Anglas wrote: > > > > Technically some exported symbols have been removed, so it would be > > a major bump. But said symbols aren't exported any more because > > meson.build now uses "gnu_symbol_visibility: 'hidden'" to build the > > library. Feel free to skip the major bump if you know that zathura > > linked against girara-0.3.0 works fine when using the library from > > girara-0.3.2. > > > > BTW there is a nice tool to check changes in exported symbols: > > /usr/src/lib/check_sym > > > > Apart from the major bump concern, I have noticed the following points > > that could be improved: > > - HOMEPAGE / MASTER_SITES could switch to https > > - WANTLIB should be refreshed (make port-lib-depeends-check) > > - libnotify is not picked up by default any more, is should either be > > explicitely activated or removed from LIB_DEPENDS > > - I switched to https, but cannot test it as the server is experiencing > turbulence at the moment. > - I updated WANTLIB following the recommendation of make > port-lib-depends-check > - the developers decided to disable libnotify by default, so I removed > the dependency > > > This makes your diff hard to apply. If you can't use cvs diff, please > > at least do something like: > > > > cd /build/usr/ports/x11/girara/ && diff -uNprx CVS /usr/ports/x11/girara . > > > > so that we don't have to guess the pathname strip count. > > I would prefer to use cvs diff, but the resulting diff does not include > new and deleted files (perhaps there is an option that I missed?).
As long as you don't need to add a directory, you can do this (works OK against anoncvs): cvs add $file cvs rm $file cvs di -uNp
