Hi Andrew,

On Sun, Jan 27, 2019 at 08:24:59PM -0700, [email protected] wrote:
> On Sun, Dec 09, 2018 at 01:57:58PM +0000, Olivier Cherrier wrote:
> > Following https://marc.info/?l=openbsd-ports&m=146753658609587&w=2,
> > here is a port for p5-Rex.
> 
> I see an empty share/examples/p5-Rex directory in the PLIST but don't
> see anything in the distribution that seems like it should live there,
> and I'm not actually sure what's creating it.  Probably it should be
> @comment'ed out.
 
Here is a small update … with an example included :)

> It looks like it needs a TEST_DEPENDS on devel/p5-Test-Deep as well as a
> new port (attached) of p5-Test-UseAllModules to pass tests.  
 
Thanks !
I added them. It is still failing for me because I have Hash::Merge in
version 0.300:
---8<---
#   Failed test 'use Rex::CMDB::YAML;'                                       
#   at /usr/local/libdata/perl5/site_perl/Test/UseAllModules.pm line 71.     
#     Tried to use 'Rex::CMDB::YAML'.                                        
#     Error:  Can't locate Clone/Choose.pm in @INC ……
---8<---

It comes from:
$ grep Choose /usr/local/libdata/perl5/site_perl/Hash/Merge.pm
use Clone::Choose 0.008;
$

With Clone::Choose installed, it ends up successfully.
This new port is attached and an update of Hash::Merge as well.

> Other than that it looks OK afresh1@
> 
> > $ cat pkg/DESCR 
> > a command line tool which executes commands on remote servers. Define
> > tasks in Perl and execute them on remote servers or groups of servers.
> > Rex can be used to:
> >     _ Deploy web applications to servers sequentially or in parallel.
> >     _ Automate common tasks.
> >     _ Provision servers using Rex's builtin tools.
> > 
> > 
> > It works great for me.
> > 
> > I created some patches for the Pkg and the User module. I'll see to send
> > them upstream.
> 
> Thanks!  I didn't look too closely at the patches, but a quick scan
> seemed mostly sane although I don't know a lot about Rex.

I submitted the patches to the Rex project and they have been integrated.
They will be in the the next release. So i think they can go in this port
for now.


Thanks,
Best

-- 
Olivier Cherrier
mailto:[email protected]

Attachment: p5-Clone-Choose.tgz
Description: application/tar-gz

Index: devel/p5-Hash-Merge/Makefile
===================================================================
RCS file: /data/OpenBSD_CVSROOT/ports/devel/p5-Hash-Merge/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- devel/p5-Hash-Merge/Makefile        20 Mar 2016 19:56:25 -0000      1.13
+++ devel/p5-Hash-Merge/Makefile        28 Jan 2019 23:00:13 -0000
@@ -4,7 +4,7 @@
 
 MODULES =      cpan
 PKG_ARCH =     *
-DISTNAME =     Hash-Merge-0.200
+DISTNAME =     Hash-Merge-0.300
 CATEGORIES =   devel
 
 MAINTAINER =   Andrew Fresh <[email protected]>
@@ -12,6 +12,7 @@
 # Perl
 PERMIT_PACKAGE_CDROM = Yes
 
-RUN_DEPENDS =  devel/p5-Clone>=0
+RUN_DEPENDS =  devel/p5-Clone>=0 \
+               devel/p5-Clone-Choose
 
 .include <bsd.port.mk>

Attachment: p5-Rex.tgz
Description: application/tar-gz

Reply via email to