On 2019/01/07 13:13, Stuart Henderson wrote: > On 2019/01/07 13:17, Sascha Paunovic wrote: > > On Mon, 7 Jan 2019 12:03:49 +0000 > > Stuart Henderson <[email protected]> wrote: > > > > > Not new with the update, but that's a bad filename for a distfile. > > > It would be better to use this: > > > > > > DISTFILES = ${DISTNAME}${EXTRACT_SUFX} \ > > > qmltermwidget-{}${QMLTERMWIDGET}.tar.gz:0 > > > > > > and regenerate distinfo. > > > > Yep, it's pretty unelegant. Quick question; would > > > > DISTFILES = ${DISTNAME}${EXTRACT_SUFX} \ > > qmltermwidget-${QMLTERMWIDGET}.tar.gz:0 > > > > also be OK? I tried it, seems to work just fine. > > -- > > Sascha Paunovic <[email protected]> > > > > It doesn't work like that: > > $ make makesum > ===> Checking files for cool-retro-term-1.1.0 > >> Fetch > >> https://github.com/Swordfish90/cool-retro-term/archive/1.1.0/cool-retro-term-1.1.0.tar.gz > >> Fetch > >> https://github.com/Swordfish90/qmltermwidget/archive/qmltermwidget-48274c75660e28d44af7c195e79accdf1bd44963.tar.gz > ftp: Error retrieving file: 404 Not Found > > The github autogenerated tar.gz URL needs to just be > archive/$commithash.tar.gz > without the prefix. > > Maybe it's worth pointing out to upstream that the tar.gz available at > https://github.com/Swordfish90/cool-retro-term/releases is unusable because > it doesn't include the qtermwidget submodule, it would be convenient for > users if they were to provide a standard tar.gz as a binary asset (similar > to how they've included the dmg for 1.0.1 and the AppImage files for the > continuous build, and similar to https://github.com/irssi/irssi/releases > and https://github.com/darktable-org/darktable/releases/), it would be > much preferable if there was just a single file to download. >
I've committed the update + the distfile name change, also regenerated PLIST because yours had a bunch of extra directories.
