On 2018/12/18 14:40, Solene Rapenne wrote:
> Solene Rapenne <[email protected]> wrote:
> > Solene Rapenne <[email protected]> wrote:
> > > this diff updates phppgadmin to 5.6 version, released a few days ago
> > > after a
> > > few years of inactivity.
> > >
> > > It happens that the "processes" tab doesn't work on older postgresql with
> > > this
> > > version... Don't know if it's a show stopper?
> > >
>
> new diff version, removing the tests from post-install as suggested by sthen@
Thanks - now that the PLIST diff is actually readable I notice this
(it's already present in the version in-tree) :
> phpPgAdmin/conf/
> +phpPgAdmin/conf/.gitignore
> phpPgAdmin/conf/config.inc.php
> phpPgAdmin/conf/config.inc.php-dist
config.inc.php is a user config file and should be handled via the
@sample mechanism so that updates don't cause conflicts with local changes.
Either this could also be removed in post-install, or commented-out in
PLIST, and then use an @sample, e.g.
phpPgAdmin/conf/config.inc.php-dist
@sample phpPgAdmin/conf/config.inc.php
Also in that file we have this ..
// Specify the path to the database dump utilities for this server.
// You can set these to '' if no dumper is available.
$conf['servers'][0]['pg_dump_path'] = '/usr/bin/pg_dump';
$conf['servers'][0]['pg_dumpall_path'] = '/usr/bin/pg_dumpall';
- with the default chroot, I think patching to '' probably makes sense.
