On Fri, Oct 26, 2018 at 03:01:44PM +0200, Antoine Jacoutot wrote:
> On Thu, Oct 25, 2018 at 08:29:57PM +0100, Stuart Henderson wrote:
> > On 2018/10/25 12:10, joshua stein wrote:
> > > A CUPS driver for Brother laser printers.
> >
> > Please set COMPILER = base-clang ports-gcc base-gcc.
>
> Also could use make your MESSAGE a README please?
> I am wiling to maintain this since there's no MAINTAINER line and I already
> maintain most (all?) print ports.
>
> Otherwise ok.
The patch can be removed, it was necessary in v3 but not anymore.
Also, make port-lib-depends-check reported some extra and missing
libraries, WANTLIB should be as follow:
WANTLIB+= ${COMPILER_LIBCXX} c cups cupsimage m
OK fcambus@ with those changes.
