On Mon, Oct 22, 2018 at 01:43:32PM +0200, Jeremie Courreges-Anglas wrote:
> Still, I don't like people completely changing the whitespace in
> a Makefile while also introducing semantic changes in the same commit.
> It makes diffs and cvs history hard to review, which is BAD. :)
Yep, that's unneeded churn on existing makefiles.
new makefiles should *preferably* have the spaces.
Another rule for which there should be no exceptions: ditch extra shells
in Makefiles.
any makefile that looks like:
target:
(cd somewhere && dosomething)
(cd elsewhere && dosomethinelse)
is *wrong wrong wrong*
individual commands are already run by separate shells. All you're doing
is adding subshells (and thus more processes) for no reason
It should be:
target:
cd somewhere && dosomething
cd elsewhere && dosomethinelse
Note that it also goes for grouping stuff in shell tests.
(a || b) && c
mostly never makes sense. The syntactic grouping is a bit awkward
{ a || b ; } && c
but at least it doesn't fork an extra subshell.
