> Sorry I don't think it's ready for commit yet, there are a few problems ..
Sure, thank you for reviewing this!
> - Bad distfile name, it's already using an on-the-fly
> tarball from github anyway so the easy fix is to use the GH_* scaffolding
>
> - Compiler command lines are hidden which makes it hard to track down some
> problems in bulk build logs
>
> - Needs WANTLIB etc.
>
> (Diff for the above three attached)
Thanks!
> - In the build of the embedded copy of libz, it's forcing "gcc -O3"
> and for lua it does use ${CC} but forces -O2, looks like forced -O2 in
> ossec's own files too?
I try not to touch hardcoded optimization levels. Which I know is a
faux-pas in our ports tree, but I tend to trust the software developers
more now that we have modern compilers in the tree.
If needed, I will fix this.
> - Patches have hardcoded /usr/local
Yes. I thought that we decided against supporting other install
directories. I can substitute them for TRUEPREFIX if needed.
> - (also it's not ideal that it's NO_BUILD and everything is built in
> "make install", though upstream doesn't make this easy to fix..)
It's a horror the way they build it. I would basically have to rewrite
the entire build system for them and then maintain it on each release.
It has already been a disgusting experience tracking down the file
permissions inside pkg/PLIST :(
