If the port you're working on has a maintainer, please include them in To: or Cc:. I just Cc'ed Kaashif.
On Sat, Sep 22, 2018 at 02:44:37PM -0400, Jake Champlin wrote: > >From mentions on bsd.network: > - Fixes pledge call to follow convention > - Adds REVISION to Makefile > - Adds `# uses pledge()` comment to Makefile These seem fine however your submission lacks important details: What did you test and how? Which promises are needed for what? Looking at it's usage and manual, I see no options to control behaviour towards the highscore file. Does that mean it's always written? If not, this would indicate code paths where it can run with less promises. In general, please explain your diffs so people don't have guess and/or redo all the work. > COMMENT = terminal version of the 2048 sliding block puzzle game > +REVISION = 0 REVISION usually goes below the version information; GH_TAGNAME in this case. This should also be a tab after "=". > Index: patches/patch-pledge > =================================================================== > RCS file: patches/patch-pledge Patches are named after the patched source file as done by `update-patches'. See bsd.port.mk(5) as well as our porting guide in our FAQ. > diff -N patches/patch-pledge > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-pledge 22 Sep 2018 18:44:16 -0000 > @@ -0,0 +1,26 @@ Missing CVS tag. > +Pledges 2048 No need for such an obvious comment imho.
