On Fri, Apr 27 2018, Pascal Stumpf <[email protected]> wrote:
> On Fri, 27 Apr 2018 11:43:37 +0200, =?utf-8?B?QmrDtnJu?= Ketelaars wrote:
>> Maintainer timeout:
>>
>> Enclosed a diff for bringing brotli to the latest version (1.0.4), which
>> brings some improvements, and fixes some issues. An overview on the
>> changes can be found at https://github.com/google/brotli/releases
>>
>> Minor number of 2 of the 3 shared libs require a bump as symbols have
>> been added.
Two symbols have been added to brotlicommon, not to brotlidec. But
brotlidec uses those new symbols, so it makes sense to bump its major
(just like we do in base with libcrypto/ssl/tls).
russell /usr/ports/archivers/brotli$ /usr/src/lib/check_sym
/usr/local/lib/libbrotlicommon.so.1.0
/usr/ports/pobj/brotli-1.0.4/fake-amd64/usr/local/lib/libbrotlicommon.so.1.1
/usr/local/lib/libbrotlicommon.so.1.0 -->
/usr/ports/pobj/brotli-1.0.4/fake-amd64/usr/local/lib/libbrotlicommon.so.1.1
Dynamic export changes:
added:
BrotliGetTransforms
BrotliTransformDictionaryWord
russell /usr/ports/archivers/brotli$ /usr/src/lib/check_sym
/usr/local/lib/libbrotlidec.so.1.0
/usr/ports/pobj/brotli-1.0.4/fake-amd64/usr/local/lib/libbrotlidec.so.1.1
/usr/local/lib/libbrotlidec.so.1.0 -->
/usr/ports/pobj/brotli-1.0.4/fake-amd64/usr/local/lib/libbrotlidec.so.1.1
No dynamic export changes
External reference changes:
added:
BrotliGetTransforms
BrotliTransformDictionaryWord
>> make test runs successfully. Consumers have been build tested.
>>
>> Comments/OK?
>>
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/archivers/brotli/Makefile,v
>> retrieving revision 1.5
>> diff -u -p -r1.5 Makefile
>> --- Makefile 5 Dec 2017 21:04:07 -0000 1.5
>> +++ Makefile 27 Apr 2018 09:39:48 -0000
>> @@ -4,10 +4,10 @@ COMMENT = generic lossless compressor
>>
>> GH_ACCOUNT = google
>> GH_PROJECT = brotli
>> -GH_TAGNAME = v1.0.2
>> +GH_TAGNAME = v1.0.4
>>
>> -SHARED_LIBS += brotlicommon 1.0 # 0.6
>> -SHARED_LIBS += brotlidec 1.0 # 0.6
>> +SHARED_LIBS += brotlicommon 1.1 # 0.6
>> +SHARED_LIBS += brotlidec 1.1 # 0.6
>> SHARED_LIBS += brotlienc 1.0 # 0.6
>
> Have you checked that this does not break the API? If not, better be
> safe and bump the shlib major.
I too a look and saw no reason for an ABI break. Some enums have been
extended, but nothing that would imply a change in their storage size on
our architectures.
> Otherwise ok pascal@.
ok jca@ too
>> CATEGORIES = archivers
>> Index: distinfo
>> ===================================================================
>> RCS file: /cvs/ports/archivers/brotli/distinfo,v
>> retrieving revision 1.4
>> diff -u -p -r1.4 distinfo
>> --- distinfo 5 Dec 2017 21:04:07 -0000 1.4
>> +++ distinfo 27 Apr 2018 09:39:48 -0000
>> @@ -1,2 +1,2 @@
>> -SHA256 (brotli-1.0.2.tar.gz) = ws8qFmRrRHcaQQm7ISGMji2VK6u4J3luuKgAwflLdCI=
>> -SIZE (brotli-1.0.2.tar.gz) = 23736359
>> +SHA256 (brotli-1.0.4.tar.gz) = Imij3/HMNuGFSeiaUe4M2VE5CKl31W1qH51MYcKvN8M=
>> +SIZE (brotli-1.0.4.tar.gz) = 23819000
>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
