On Thu, Mar 08, 2018 at 05:49:51PM +0100, Ljuba Nedeljkovic wrote:
> Attached is the port of nnn, "The missing terminal file browser for X"
>
> Apart from development machine (amd64) it was tested on clean base
> OpenBSD install also on amd64. Additional tests/comments/ok would be
> highly appreciated.
COMMENT starts with an upper case letter.
As a github project without proper release tarballs, please use GH_*.
Can you communicate with upstream to provide stable release tarballs?
They're already packaging for linux, so this shouldn't take much effort.
The license marker is missing.
WRK{DIST,SRC,BUILD} can go once GH_* is set.
PLIST contains an empty line.
Sources provide shell completions, what about packaging them as well?
There is no need for patch-Makefile, you can pass these variables in
various ways.
For replacing the shebang please see LOCALBASE in bsd.port.mk(5). This
also implies a missing RDEP on shells/bash.
https://www.openbsd.org/faq/ports/guide.html is helpful in getting these
fixed, but you can also look at other ports.
