On Sun 14/01/2018 12:44, Stuart Henderson wrote:
> On 2018/01/14 11:14, Landry Breuil wrote:
> > On Sun, Jan 14, 2018 at 11:09:05AM +0100, Björn Ketelaars wrote:
> > > On Sun 14/01/2018 10:10, Landry Breuil wrote:
> > > > On Sun, Jan 14, 2018 at 08:41:34AM +0100, Björn Ketelaars wrote:
> > > > > Enclosed a diff for bringing joe to the latest version (4.6), which
> > > > > fixes
> > > > > a couple of bugs. Changelog can be found at
> > > > > https://sourceforge.net/p/joe-editor/mercurial/ci/default/tree/NEWS.md
> > > > >
> > > > > Output of 'make lib-depends-check' indicates that curses should be
> > > > > included as
> > > > > WANTLIB instead of ncurses.
> > > > >
> > > > > Comments?
> > > >
> > > > Maybe portcheck warns about it, but if somehonw files are added into
> > > > share/applications; then you need to run depends on desktop-file-utils,
> > > > update the plist so that the share/applications dir is removed from it,
> > > > and add the corresponding @exec @unexec-delete goos as found in many
> > > > other ports. Or if you dont want to add the dependency, @comment the
> > > > entries so that they're not installed.
> > >
> > > Yes...portcheck warns about files in share/applications, and about
> > > desktop-file-utils. My mistake.
> > >
> > > New diff:
> >
> > this one is okay for me if someone wants to commit it.
> >
>
> The .desktop files are broken, "Exec=/usr/bin/joe %F"
>
> Easy to patch, but do we really want an X dependency for a simple text
> editor? It's the sort of thing you might install on a firewall for
> someone who isn't comfortable with vi/mg.
My primary use case for joe is offering a young family member a relative easy
terminal editor. There is no need for X. Of course, this use case is only one
of many.
For reference purposes, my use case is best served by the diff below.
diff --git editors/joe/Makefile editors/joe/Makefile
index 2e0b050fe74..cecdeb0a8dc 100644
--- editors/joe/Makefile
+++ editors/joe/Makefile
@@ -2,7 +2,7 @@
COMMENT= Joe's Own Editor
-DISTNAME= joe-4.5
+DISTNAME= joe-4.6
CATEGORIES= editors
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=joe-editor/}
@@ -11,7 +11,7 @@ HOMEPAGE= http://joe-editor.sourceforge.net/
# GPLv2 only
PERMIT_PACKAGE_CDROM= Yes
-WANTLIB= c ncurses m util
+WANTLIB= c curses m util
BUILD_DEPENDS= converters/libiconv
diff --git editors/joe/distinfo editors/joe/distinfo
index 6c37e9ba4e8..efbad7ef60a 100644
--- editors/joe/distinfo
+++ editors/joe/distinfo
@@ -1,2 +1,2 @@
-SHA256 (joe-4.5.tar.gz) = URBKo02GUL4/pJ8iBGcqUXaIyebsR+aPHqhd6I42yt8=
-SIZE (joe-4.5.tar.gz) = 1275486
+SHA256 (joe-4.6.tar.gz) = SVoKYfJkBAcP6KcZ2AQG3H8zdiN4jkRbkqn23lEqud4=
+SIZE (joe-4.6.tar.gz) = 1895046
diff --git editors/joe/pkg/PLIST editors/joe/pkg/PLIST
index 9d337f09bf0..1f415e1b7e6 100644
--- editors/joe/pkg/PLIST
+++ editors/joe/pkg/PLIST
@@ -8,6 +8,11 @@ bin/rjoe
man/ru/
man/ru/man1/
@man man/ru/man1/joe.1
+@comment share/applications/
+@comment share/applications/jmacs.desktop
+@comment share/applications/joe.desktop
+@comment share/applications/jpico.desktop
+@comment share/applications/jstar.desktop
share/doc/joe/
share/doc/joe/ChangeLog
share/doc/joe/NEWS.md
