On Mon, Jan 08, 2018 at 11:42:37PM -0500, Brian Callahan wrote:
> Hi Thomas and ports --
>
> I noticed tonight that SDL2 uses -msse, -msse2, and -msse3 flags by default
> (at least on amd64). Is this what we want? On one hand, SSE3 was introduced
> 14 years ago, so perhaps it is reasonable to say that if your CPU is 15
> years old or older, then maybe nothing SDL2 will work well. But I don't know
> if that's necessarily true.
>
> Attached is the heavy hammer disabling all of SSE. This leaves in MMX and
> 3DNow! flags, as I do think it's reasonable to say that CPU that pre-date
> those extensions are probably too slow to run anything SDL2 at a usable
> speed.
SSE/SSE2 at least is unconditionally available for amd64. There may also be
cpuid based runtime checks for the instructions so this diff seems wrong.
>
> Not necessarily looking for OKs, looking to make sure that we are OK with
> whatever SSE selection we decide on.
>
> ~Brian
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/sdl2/Makefile,v
> retrieving revision 1.19
> diff -u -p -u -p -r1.19 Makefile
> --- Makefile 7 Jan 2018 22:56:46 -0000 1.19
> +++ Makefile 9 Jan 2018 04:32:33 -0000
> @@ -7,6 +7,7 @@ BROKEN-hppa= src/atomic/SDL_spinlock.c:1
> V= 2.0.7
> DISTNAME= SDL2-${V}
> PKGNAME= sdl2-${V}
> +REVISION= 0
> CATEGORIES= devel
> MASTER_SITES= http://www.libsdl.org/release/
>
> @@ -41,7 +42,10 @@ CONFIGURE_ARGS+= --disable-alsa \
> --disable-libudev \
> --disable-nas \
> --disable-oss \
> - --disable-pulseaudio
> + --disable-pulseaudio \
> + --disable-sse \
> + --disable-sse2 \
> + --disable-sse3
> # in case devel/usb is installed, don't pick it up.
> CONFIGURE_ENV+= ac_cv_lib_usb_hid_init=no \
> ac_cv_header_usb_h=no
