On Mon, 2017-12-11 at 22:56 +0100, Landry Breuil wrote:
> Oh, and now that i thought a bit more about your diff (that i haven't
> actually *tested* yet), i don't see any change in the build
> config/patches, so how have you 'placed the sample luminaDesktop.conf
> file in the correct place' ? If you manually edit PLIST, that's not
> how
> it works...
> 
> make fake will run 'make install' in the work dir, pointing at a
> temporary fake hierarchy, and make update-plist will list files in
> the
> given hierarchy, and update PLIST with files it found there. So if
> you
> want to fix the install location, you have to rewind a step before,
> and
> either fix the arguments passed to the lumina build system to make
> sure
> it installs this config file at the right place (not hardcoding paths
> inside the code to the 'wrong' location, since the actual location at
> runtime will be the @sample'd one) or patch the makefiles so that it
> uses the 'runtime' location inside the code (i wouldnt be surprised
> it's
> hardcoded somewhere in the code) and adapt only the install path
> during
> fake.
> 
> dammit, sometimes, ports is hard. Maybe re-read the ports faq and
> pkg_create ?
> Oh and of course maybe it's actually fixed the right way already, and
> i'm talking out of my ***.
> 
Landry,

Love your feedback.  Please keep educating me!  

What I did relative to the luminaDesktop.conf is in the post-install
hook in the Makefile move the file to the right place.  Is that the
right way to do it?

Thanks.

Reply via email to