Hi Karel,
On Sun, Dec 10, 2017 at 08:22:54PM +0100, Karel Gardas wrote:
> rts/Linker.c includes elf.h for all platform except OpenBSD where it
> includes elf_abi.h. In recent snapshots elf_abi.h got removed thanks
> to work of Martin Pieuchot.
But it's still there, even in todays snapshots:
$ tar tvzf comp62.tgz ./usr/include/elf\*
-r--r--r-- 1 root bin 166 Dec 10 19:09 ./usr/include/elf.h
-r--r--r-- 1 root bin 1627 Dec 10 19:09 ./usr/include/elf_abi.h
And the same is true for a release(8) i just built on my build
machine.
Maybe you used a snapshot with elf_abi.h missing (intentionally or not).?
> This way, rts/Linker.c includes
> non-existent .h file which fails. My "fix" for now is simple to just
> s/elf_abi/elf and be done with this for now.
This will have to be done at some point in time, but as long as
snapshots still contain both elf.h and elf_abi.h, I don't see the
point to add any patch for this.
> As you may see in the
> OpenBSD related define there are other things missing in OpenBSD's elf
> support,
Yeah. including my horrible undef SHN_XINDEX hack I had to add for
ghc-8.0 ;-)
> but I'm plan for reviewing this in the future anyway -- hence
> my minimalistic way of fixing for now.
That would be great (and I'm really no expert in the rts/Linker.c area).
> If your plans are different, then go ahead with whatever you plan and
> do not keep looking back at all.
My plan is to get a newer version of ghc (8.2.x) in the ports tree first.
*Then* we can start to add patches to the port (when needed) which may
also be appropriate for upstream.
Ciao,
Kili
